Disable attached_pic

This feature causes crashes during file streaming on Windows. UnitTest has also been removed.

Author: hwangsihu

Library/TeamTalkLib/avstream/FFmpegStreamer.cpp

@@ -154,6 +154,13 @@ bool OpenInput(const ACE_TString& filename,
     /* select the video stream */
     video_stream_index = av_find_best_stream(fmt_ctx, AVMEDIA_TYPE_VIDEO,
                                              -1, -1, &vid_dec, 0);
+    if (video_stream_index >= 0) {
+        const AVStream* vidstream = fmt_ctx->streams[video_stream_index];
+        if (vidstream->disposition & AV_DISPOSITION_ATTACHED_PIC)
+        {
+            video_stream_index = -1;
+        }
+    }
     if (video_stream_index >= 0) {
         const AVStream* vidstream = fmt_ctx->streams[video_stream_index];
         const AVCodecParameters* vidparms = vidstream->codecpar;

Library/TeamTalkLib/test/CatchDefault.cpp

@@ -1782,48 +1782,6 @@ TEST_CASE("TT_AEC")
 }
 #endif
 
-#if defined(ENABLE_FFMPEG)
-TEST_CASE("testThumbnail")
-{
-    // ffmpeg -i in.mp3 -i teamtalk.png -map 0:0 -map 1:0 -c copy -id3v2_version 3 -metadata:s:v title="Album cover" -metadata:s:v comment="Cover (front)" out.mp3
-
-    TTCHAR filename[TT_STRLEN] = ACE_TEXT("testdata/mp3/thumbnail.mp3");
-
-    MediaFileProp mfp;
-    REQUIRE(GetMediaFileProp(filename, mfp));
-    REQUIRE(mfp.video.IsValid());
-
-    MediaStreamOutput const prop(media::AudioFormat(16000, 2), 1600, media::FOURCC_NONE);
-    FFmpegStreamer ffmpeg(filename, prop);
-
-    REQUIRE(ffmpeg.Open());
-
-    std::promise<bool> done;
-    auto sig_done = done.get_future();
-
-    auto status = [&] (const MediaFileProp&  /*mfp*/, MediaStreamStatus status) {
-                      if (status == MEDIASTREAM_FINISHED)
-                          done.set_value(true);
-                  };
-
-    auto audio = [] (media::AudioFrame& /*audio_frame*/, ACE_Message_Block* /*mb_audio*/) {
-                     return false;
-                 };
-
-    auto video = [] (media::VideoFrame& /*video_frame*/, ACE_Message_Block* /*mb_video*/) {
-                    return false;
-                };
-
-    ffmpeg.RegisterStatusCallback(status, true);
-    ffmpeg.RegisterAudioCallback(audio, true);
-    ffmpeg.RegisterVideoCallback(video, true);
-
-    REQUIRE(ffmpeg.StartStream());
-
-    REQUIRE(sig_done.get());
-}
-#endif
-
 #if defined(ENABLE_ENCRYPTION)
 
 TEST_CASE("testSSLNonBlockConnector")