Commit 844d03c
authored
## Summary
This PR removes the pinned CI constraints file and updates
code/tests/docstrings to align with current pandas behaviors (datetime
units and type repr changes).
## Key changes
### CI
- Remove `ci_constraints.txt` (previously pinned `numpy==2.2.6` and
`pandas==2.3.3`).
- Update GitHub Actions workflow to install Arkouda dev dependencies
**without** `-c ci_constraints.txt`:
- `python3 -m pip install .[dev]`
### Datetime / Timedelta internals
- In `arkouda/numpy/timeclass.py`, simplify initialization from
`pandas.Series`:
- Assume `from_series()` returns **int64 nanoseconds** for
datetime/timedelta.
- Set `unit` to `"ns"` and `_factor` to `1`, and remove the extra
scaling logic.
### Docstring / repr updates for pandas
- Update docstring examples to reflect newer pandas type display paths:
- `pandas.core.*` → `pandas.*` / `pandas.arrays.*`
- In `arkouda/pandas/series.py`, relax dtype display in example output
(`dtype: ...`) to avoid brittle expectations.
### Test updates
- Datetime accessor test:
- Normalize both sides to `datetime64[ns]` before
`pd_assert_series_equal` to avoid unit/metadata mismatches.
- DataFrame groupby tests:
- Use explicit column selection with `groupby(...)[[cols]].sum()` where
appropriate.
- Use `sum(numeric_only=True)` to avoid pandas warnings / behavior
differences around non-numeric columns.
## Why
- CI constraints were causing avoidable friction and are redundant with
modern dependency management.
- Pandas has evolved in:
- datetime dtype/unit handling and metadata,
- public type paths/reprs,
- groupby summation behavior and `numeric_only` defaults/warnings.
This PR reduces brittleness and keeps Arkouda’s integration aligned with
upstream pandas.
## Testing
- CI workflow updated to ensure installs succeed without constraints.
- Updated unit tests for datetime accessor and groupby aggregation to
pass reliably across supported pandas versions.
Closes #5327: Normalize datetime and string dtypes to match NumPy/Pandas
defaults
---------
Co-authored-by: ajpotts <ajpotts@users.noreply.github.com>
1 parent f936b95 commit 844d03c
File tree
10 files changed
+23
-31
lines changed- .github/workflows
- arkouda
- numpy
- pandas
- extension
- tests/pandas
10 files changed
+23
-31
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| |||
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
428 | | - | |
| 428 | + | |
429 | 429 | | |
430 | 430 | | |
431 | 431 | | |
| |||
476 | 476 | | |
477 | 477 | | |
478 | 478 | | |
479 | | - | |
| 479 | + | |
480 | 480 | | |
481 | 481 | | |
482 | 482 | | |
| |||
534 | 534 | | |
535 | 535 | | |
536 | 536 | | |
537 | | - | |
| 537 | + | |
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
| |||
602 | 602 | | |
603 | 603 | | |
604 | 604 | | |
605 | | - | |
| 605 | + | |
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
125 | 123 | | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | 124 | | |
133 | 125 | | |
134 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
347 | | - | |
| 347 | + | |
348 | 348 | | |
349 | 349 | | |
350 | 350 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
366 | 366 | | |
367 | 367 | | |
368 | 368 | | |
369 | | - | |
| 369 | + | |
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
228 | | - | |
| 228 | + | |
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1337 | 1337 | | |
1338 | 1338 | | |
1339 | 1339 | | |
1340 | | - | |
| 1340 | + | |
1341 | 1341 | | |
1342 | 1342 | | |
1343 | 1343 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
131 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
132 | 134 | | |
133 | 135 | | |
134 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
718 | 718 | | |
719 | 719 | | |
720 | 720 | | |
721 | | - | |
| 721 | + | |
722 | 722 | | |
723 | 723 | | |
724 | 724 | | |
725 | 725 | | |
726 | | - | |
727 | | - | |
728 | | - | |
| 726 | + | |
729 | 727 | | |
730 | 728 | | |
731 | 729 | | |
732 | 730 | | |
733 | | - | |
| 731 | + | |
734 | 732 | | |
735 | 733 | | |
736 | 734 | | |
737 | 735 | | |
738 | | - | |
| 736 | + | |
739 | 737 | | |
740 | 738 | | |
741 | 739 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
| 223 | + | |
| 224 | + | |
223 | 225 | | |
224 | 226 | | |
225 | 227 | | |
| |||
0 commit comments