Add support for recursive field reference resolution in formula fields #79825

mukhrr · 2026-01-18T06:11:52Z

Explanation of Change

Fixed Issues

$ #74651
PROPOSAL: #74651 (comment)

Tests

Create a new report field named “B” (Text) with Initial value “value_1”
Create a new report field named “A” (Text) with Initial value set to {field:B}
Go to the workspace chat and create a report
Observe both report fields display as “value_1”
Try changing report field values to new ones

Verify both changes to the same value without any page refresh
Verify that no errors appear in the JS console

Offline tests

QA Steps

The same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

https://github.com/user-attachments/assets/a488a849-0895-4428-a8ea-f29597dbd293

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web.mp4

This change enables formula fields to recursively resolve field references when computing values. When a field's default value contains {field:X} references, the system now: - Parses the default value to detect field references - Recursively computes referenced field values using their current default values - Ignores stale 'value' properties when resolving dependencies - Supports multi-level chaining (e.g., C -> A -> B)

codecov · 2026-01-18T06:21:27Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...RequestReportView/MoneyRequestViewReportFields.tsx	`0.00% <0.00%> (ø)`
src/libs/Formula.ts	`87.75% <88.46%> (+1.18%)`	⬆️
...rc/components/ReportActionItem/MoneyReportView.tsx	`0.00% <0.00%> (ø)`
src/libs/ReportUtils.ts	`71.88% <0.00%> (-0.23%)`	⬇️
... and 83 files with indirect coverage changes

melvin-bot · 2026-01-20T17:42:52Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Formula.ts

src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

src/components/ReportActionItem/MoneyReportView.tsx

src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx

src/libs/ReportUtils.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a34a8e9e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/Formula.ts

- Extract field value resolution into resolveReportFieldValue helper in Formula library - Add circular reference prevention for field dependencies - Combine getReportFieldValues and getReportFieldsByName into single getReportFieldMaps function - Optimize field map generation with single-pass iteration - Add quick string check before expensive formula parsing

ikevin127 · 2026-01-21T01:13:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

ikevin127

✅ Completed reviewer checklist - changes look good, only have 2 comments.

src/libs/Formula.ts

tests/unit/FormulaTest.ts

…elper

mukhrr · 2026-01-21T03:27:40Z

@ikevin127 thanks for review. It's ready now

ikevin127

✅ LGTM - Thanks for the changes!

OSBotify · 2026-01-21T10:16:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-21T23:38:14Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned mukhrr Jan 18, 2026

mukhrr added 2 commits January 20, 2026 21:39

Merge remote-tracking branch 'origin' into fix/74651

9aae624

Refactor: simplify sortedPolicyReportFields formatting

3a34a8e

mukhrr marked this pull request as ready for review January 20, 2026 17:42

mukhrr requested review from a team as code owners January 20, 2026 17:42

melvin-bot bot requested review from ikevin127 and joekaufmanexpensify and removed request for a team January 20, 2026 17:42