-
Notifications
You must be signed in to change notification settings - Fork 492
Open
Labels
COULDP3: Nice-to-have features with minimal impact if left out; included if time permitsP3: Nice-to-have features with minimal impact if left out; included if time permitschoreLinting, formatting, dependency hygiene, or project maintenance choresLinting, formatting, dependency hygiene, or project maintenance choresdocumentationImprovements or additions to documentationImprovements or additions to documentationpythonPython / backend development (FastAPI)Python / backend development (FastAPI)testingTesting (unit, e2e, manual, automated, etc)Testing (unit, e2e, manual, automated, etc)
Milestone
Description
Overview
Clean up legacy mcpgateway.validators compatibility references so docs/tests point to the canonical mcpgateway.common.validators, and decide whether to retire the shim.
Current State
mcpgateway/validators.pyre-exportsSecurityValidatorfor backward compatibility.docs/docs/architecture/security-features.mdreferencesmcpgateway/validators.py(non-canonical path).tests/security/test_input_validation.pyincludes a coverage comment with--cov=mcpgateway.validators.- No in-repo imports of
mcpgateway.validatorsfound via search.
Proposed Implementation
- Update docs mention to
mcpgateway.common.validators. - Update/remove the
--cov=mcpgateway.validatorscomment intests/security/test_input_validation.py. - Confirm external consumers and then either:
- remove
mcpgateway/validators.py, or - keep it with a deprecation note + removal timeline.
- remove
Acceptance Criteria
- No references to
mcpgateway/validators.pyormcpgateway.validatorsremain in the repo. SecurityValidatorusage continues viamcpgateway.common.validators.- Decision recorded on shim removal vs. deprecation.
Metadata
Metadata
Assignees
Labels
COULDP3: Nice-to-have features with minimal impact if left out; included if time permitsP3: Nice-to-have features with minimal impact if left out; included if time permitschoreLinting, formatting, dependency hygiene, or project maintenance choresLinting, formatting, dependency hygiene, or project maintenance choresdocumentationImprovements or additions to documentationImprovements or additions to documentationpythonPython / backend development (FastAPI)Python / backend development (FastAPI)testingTesting (unit, e2e, manual, automated, etc)Testing (unit, e2e, manual, automated, etc)