Merge pull request #316 from KristjanESPERANTO/release

Fix issue with bundled modules + some minor changes

Author: KristjanESPERANTO

.github/ISSUE_TEMPLATE/Bug_report.yml

@@ -9,7 +9,7 @@ body:
         You should have the steps to being able to reproduce this bug, for us to check if it's truly a bug.
 
         Also, you accept that, if this issue it's invalid in any way, will be discarded without receiving any response about it.
-        If you're not sure if it's a bug, please [ask here](https://github.com/ezeholz/MMM-Remote-Control/discussions).
+        If you're not sure if it's a bug, please [ask here](https://github.com/Jopyth/MMM-Remote-Control/discussions).
         
         Thanks for taking the time to help Remote Control get better every day!
   - type: input
@@ -94,7 +94,7 @@ body:
       description: |
         Paste the log you're getting, and possibly the error.
         **Please, make sure that none of your personal information, such as IP or passwords are exposed.**
-      render: shell
+      render: Shell
     validations:
       required: true
   - type: textarea
@@ -107,7 +107,7 @@ body:
         - IPs from MM instance, or the ones that are whitelisted. Please, replace them with *** so we're totally sure that you have set them.
         - API keys, Tokens from different modules, URL to private calendars.
         - Directions or Personal data.
-      render: javascript
+      render: JavaScript
     validations:
       required: true
   - type: textarea

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: false
 contact_links:
   - name: Discussions
-    url: https://github.com/ezeholz/MMM-Remote-Control/discussions
+    url: https://github.com/Jopyth/MMM-Remote-Control/discussions
     about: Don't know how to do it? Ask the community!

CHANGELOG.md

@@ -5,6 +5,20 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](https://semver.org/).
 
+## [2.5.2] - 2025-01-18
+
+### Fixed
+
+- Fixed an issue with bundled modules (reported in #302) - the defaults of some bundled modules could not be read.
+- Fixed/Updated some URLs.
+
+### Changed
+
+- Replaced `lodash` with built-in JavaScript functions.
+- Format and handle some linting issues in `node_helper.js`.
+- Switch LICENSE file to markdown for better readability.
+- Update `devDependencies`.
+
 ## [2.5.1] - 2024-12-17
 
 ### Fixed
@@ -91,7 +105,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 ### Fixed
 
 - `Find` it's not defined inside some Electron instances (#242 and #235)
-- `undefined` modules generated by the `disabled` tag are now handled. (MichMich/MagicMirror#2382)
+- `undefined` modules generated by the `disabled` tag are now handled. (MagicMirrorOrg/MagicMirror#2382)
 
 ## [2.3.0] - 2020-12-23
 
@@ -202,7 +216,7 @@ Now requires MagicMirror² version 2.7.
 
 - Path to font awesome icons
 - A few typos in `ca` and `es` translations
-- Updates to `remote.html` to support new `basePath` feature in MM `config.js`, [follow up to this MM issue](https://github.com/MichMich/MagicMirror/issues/1973), related to #185
+- Updates to `remote.html` to support new `basePath` feature in MM `config.js`, [follow up to this MM issue](https://github.com/MagicMirrorOrg/MagicMirror/issues/1973), related to #185
 
 ## [2.0.0] - 2019-02-21
 
@@ -283,7 +297,7 @@ Huge shout out to [shbatm](https://github.com/shbatm) for his work on this new m
 
 ### Fixed
 
-- Icon paths adapted to changes in [MagicMirror²](https://github.com/MichMich/MagicMirror) 2.1.0
+- Icon paths adapted to changes in [MagicMirror²](https://github.com/MagicMirrorOrg/MagicMirror) 2.1.0
 
 ## [1.1.2] - 2017-02-01
 
@@ -296,15 +310,15 @@ Huge shout out to [shbatm](https://github.com/shbatm) for his work on this new m
 ### Changed
 
 - Installation process updated in [README.md](README.md#Installation)
-- Automatic installer/updater includes hint to restart [MagicMirror²](https://github.com/MichMich/MagicMirror)
+- Automatic installer/updater includes hint to restart [MagicMirror²](https://github.com/MagicMirrorOrg/MagicMirror)
 
 ### Fixed
 
 - Issues with not applying shown and hidden status correctly to modules
 - Issues where lockstrings were missing
 - Modules sometimes did not show correctly in the UI as hidden or shown:
-  - This is due to a bug in [MagicMirror²](https://github.com/MichMich/MagicMirror)
-  - PR [#659](https://github.com/MichMich/MagicMirror/pull/659) to fix this was made in the project, will be released in the next version
+  - This is due to a bug in [MagicMirror²](https://github.com/MagicMirrorOrg/MagicMirror)
+  - PR [#659](https://github.com/MagicMirrorOrg/MagicMirror/pull/659) to fix this was made in the project, will be released in the next version
 
 ## [1.1.1] - 2017-01-26
 

LICENSE LICENSE.mdLICENSE renamed to LICENSE.md

@@ -1,6 +1,6 @@
-MIT License
+# The MIT License (MIT)
 
-Copyright (c) 2016 Joseph Bethge
+Copyright © 2016 Joseph Bethge
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -36,21 +36,21 @@ npm install
 - (2) Add the module to your `config/config.js` file, if you add a `position`, it will display the URL to the remote on the mirror.
 
 ```js
-{
-    module: 'MMM-Remote-Control',
-    // uncomment the following line to show the URL of the remote control on the mirror
-    // position: 'bottom_left',
-    // you can hide this module afterwards from the remote control itself
-    config: {
-        customCommand: {},  // Optional, See "Using Custom Commands" below
-        showModuleApiMenu: true, // Optional, Enable the Module Controls menu
-        secureEndpoints: true, // Optional, See API/README.md
-        // uncomment any of the lines below if you're gonna use it
-        // customMenu: "custom_menu.json", // Optional, See "Custom Menu Items" below
-        // apiKey: "", // Optional, See API/README.md for details
-        // classes: {} // Optional, See "Custom Classes" below
-    }
-},
+    {
+        module: 'MMM-Remote-Control',
+        // uncomment the following line to show the URL of the remote control on the mirror
+        // position: 'bottom_left',
+        // you can hide this module afterwards from the remote control itself
+        config: {
+            customCommand: {},  // Optional, See "Using Custom Commands" below
+            showModuleApiMenu: true, // Optional, Enable the Module Controls menu
+            secureEndpoints: true, // Optional, See API/README.md
+            // uncomment any of the lines below if you're gonna use it
+            // customMenu: "custom_menu.json", // Optional, See "Custom Menu Items" below
+            // apiKey: "", // Optional, See API/README.md for details
+            // classes: {} // Optional, See "Custom Classes" below
+        }
+    },
 ```
 
 - (3) For security reasons, the MagicMirror² (and therefore the Remote Control) is *not* reachable externally.
@@ -279,20 +279,4 @@ An example menu is provided in this module's folder, titled `custom_menu.example
 
 ## License
 
-### The MIT License (MIT)
-
-Copyright © 2016 Joseph Bethge
-
-Permission is hereby granted, free of charge, to any person
-obtaining a copy of this software and associated documentation
-files (the “Software”), to deal in the Software without
-restriction, including without limitation the rights to use,
-copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the
-Software is furnished to do so, subject to the following
-conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-**The software is provided “as is”, without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. In no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.**
+This project is licensed under the MIT License - see the [LICENSE](LICENSE.md) file for details.

modules.json

@@ -1124,7 +1124,7 @@
     "id": "sebastianhodapp/MMM-IndoorTemp",
     "url": "https://github.com/sebastianhodapp/MMM-IndoorTemp",
     "author": "sebastianhodapp",
-    "desc": "The module emits the notification \"INDOOR_TEMPERATURE\" to display the indoor temperature received via a subscribed MQTT topic in the default [Weather module](https://github.com/MichMich/MagicMirror/tree/develop/modules/default/weather)."
+    "desc": "The module emits the notification \"INDOOR_TEMPERATURE\" to display the indoor temperature received via a subscribed MQTT topic in the default [Weather module](https://github.com/MagicMirrorOrg/MagicMirror/tree/develop/modules/default/weather)."
   },
   {
     "longname": "MMM-meteoblueCurrent",