Refactor: Load DeviceLocales less often

Previously, [DeviceLocales.load()] was called everytime the keyboard was
shown on the screen. This operation is moderately costly and only need
to be done when the IME subtype changes.

Author: Julow

srcs/juloo.keyboard2/Keyboard2.java

@@ -41,6 +41,8 @@ public class Keyboard2 extends InputMethodService
   private KeyboardData _currentSpecialLayout;
   /** Layout associated with the currently selected locale. Not 'null'. */
   private KeyboardData _localeTextLayout;
+  /** Installed and current locales. */
+  private DeviceLocales _device_locales;
   private Dictionaries _dictionaries;
   private ViewGroup _emojiPane = null;
   private ViewGroup _clipboard_pane = null;
@@ -126,6 +128,7 @@ public void onCreate()
     _config.handler = _keyeventhandler;
     prefs.registerOnSharedPreferenceChangeListener(this);
     Logs.set_debug_logs(getResources().getBoolean(R.bool.debug_logs));
+    refreshSubtypeImm();
     create_keyboard_view();
     ClipboardHistoryService.on_startup(this, _keyeventhandler);
     _foldStateTracker.setChangedCallback(() -> { refresh_config(); });
@@ -154,26 +157,26 @@ private void refreshSubtypeImm()
   {
     _config.shouldOfferVoiceTyping = true;
     KeyboardData default_layout = null;
-    DeviceLocales locales = DeviceLocales.load(this);
-    if (locales.default_ != null)
+    _device_locales = DeviceLocales.load(this);
+    if (_device_locales.default_ != null)
     {
-      String layout_name = locales.default_.default_layout;
+      String layout_name = _device_locales.default_.default_layout;
       if (layout_name != null)
         default_layout = LayoutsPreference.layout_of_string(getResources(), layout_name);
     }
-    _config.extra_keys_subtype = locales.extra_keys();
+    _config.extra_keys_subtype = _device_locales.extra_keys();
     if (default_layout == null)
       default_layout = loadLayout(R.xml.latn_qwerty_us);
     _localeTextLayout = default_layout;
-    refresh_current_dictionary(locales.default_);
   }
 
-  private void refresh_current_dictionary(DeviceLocales.Loc current_locale)
+  private void refresh_current_dictionary()
   {
     _config.current_dictionary = null;
-    if (current_locale.dictionary == null)
+    String current = _device_locales.default_.dictionary;
+    if (current == null)
       return;
-    Cdict[] dicts = _dictionaries.load(current_locale.dictionary);
+    Cdict[] dicts = _dictionaries.load(current);
     if (dicts == null)
       return;
     _config.current_dictionary = Dictionaries.find_by_name(dicts, "main");
@@ -195,7 +198,7 @@ private void refresh_config()
   {
     int prev_theme = _config.theme;
     _config.refresh(getResources(), _foldStateTracker.isUnfolded(), _dictionaries);
-    refreshSubtypeImm();
+    refresh_current_dictionary();
     // Refreshing the theme config requires re-creating the views
     if (prev_theme != _config.theme)
     {