Commit 9711fe3
authored
Fix Windows workflow bug and harden CI workflows with --only-binary=:all: (#1493)
Fix bug in Windows workflow where pip install used '.' directory instead
of wheel files, causing setuptools-scm to build from source in shallow
clones and produce invalid fallback versions (0.1.dev...). The bug was
noticed because pathfinder was first built with an invalid version number
due to the shallow clone, and only then replaced with a wheel in a
subsequent step.
Changes:
- Windows: Change 'pip install .' to 'pip install ./*.whl' to prevent source builds
- Linux: Already had the correct pattern, but add --only-binary=:all:
- Both workflows: Systematically add --only-binary=:all: to all pip install
commands to make intent explicit and guard against accidental source builds
This ensures CI tests the exact artifacts that would be distributed.1 parent 264524b commit 9711fe3
File tree
2 files changed
+5
-7
lines changed- .github/workflows
2 files changed
+5
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
| 272 | + | |
273 | 273 | | |
274 | | - | |
| 274 | + | |
275 | 275 | | |
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
281 | | - | |
282 | | - | |
283 | 281 | | |
284 | 282 | | |
285 | 283 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
| 239 | + | |
240 | 240 | | |
241 | | - | |
| 241 | + | |
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | | - | |
| 248 | + | |
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
| |||
0 commit comments