Skip to content

Commit ba7df6a

Browse files
committed
test: refactor MiddleOfLinkedListTest to improve readability and assertions
1 parent d46a065 commit ba7df6a

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

src/test/java/com/thealgorithms/datastructures/lists/MiddleOfLinkedListTest.java

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.thealgorithms.datastructures.lists;
22

33
import static org.junit.jupiter.api.Assertions.assertEquals;
4+
import static org.junit.jupiter.api.Assertions.assertNotNull;
45
import static org.junit.jupiter.api.Assertions.assertNull;
56

67
import org.junit.jupiter.api.Test;
@@ -24,25 +25,33 @@ private static SinglyLinkedListNode listOf(int... values) {
2425
@Test
2526
void middleNodeOddLength() {
2627
SinglyLinkedListNode head = listOf(1, 2, 3, 4, 5);
27-
assertEquals(3, MiddleOfLinkedList.middleNode(head).value);
28+
SinglyLinkedListNode middle = MiddleOfLinkedList.middleNode(head);
29+
assertNotNull(middle);
30+
assertEquals(3, middle.value);
2831
}
2932

3033
@Test
3134
void middleNodeEvenLengthReturnsSecondMiddle() {
3235
SinglyLinkedListNode head = listOf(1, 2, 3, 4, 5, 6);
33-
assertEquals(4, MiddleOfLinkedList.middleNode(head).value);
36+
SinglyLinkedListNode middle = MiddleOfLinkedList.middleNode(head);
37+
assertNotNull(middle);
38+
assertEquals(4, middle.value);
3439
}
3540

3641
@Test
3742
void middleNodeSingleElement() {
3843
SinglyLinkedListNode head = listOf(42);
39-
assertEquals(42, MiddleOfLinkedList.middleNode(head).value);
44+
SinglyLinkedListNode middle = MiddleOfLinkedList.middleNode(head);
45+
assertNotNull(middle);
46+
assertEquals(42, middle.value);
4047
}
4148

4249
@Test
4350
void middleNodeTwoElementsReturnsSecond() {
4451
SinglyLinkedListNode head = listOf(10, 20);
45-
assertEquals(20, MiddleOfLinkedList.middleNode(head).value);
52+
SinglyLinkedListNode middle = MiddleOfLinkedList.middleNode(head);
53+
assertNotNull(middle);
54+
assertEquals(20, middle.value);
4655
}
4756

4857
@Test
@@ -61,7 +70,9 @@ void middleNodeDoesNotModifyListStructure() {
6170
second.next = third;
6271
third.next = fourth;
6372

64-
assertEquals(3, MiddleOfLinkedList.middleNode(first).value);
73+
SinglyLinkedListNode middle = MiddleOfLinkedList.middleNode(first);
74+
assertNotNull(middle);
75+
assertEquals(3, middle.value);
6576

6677
assertEquals(second, first.next);
6778
assertEquals(third, second.next);

0 commit comments

Comments
 (0)