fix: make deploy client fail on bad request

Author: gmolki

scripts/deploy/client.py

@@ -13,43 +13,23 @@
 
 def build_parser() -> argparse.ArgumentParser:
     p = argparse.ArgumentParser(description="Deploy request client")
-    p.add_argument(
-      "--cid",
-      required=True,
-      help="IPFS CID of the build tarball"
-    )
-    p.add_argument(
-      "--app",
-      required=True,
-      help="Application name on the server"
-    )
-    p.add_argument(
-        "--url",
-        required=True,
-        help="Deploy service URL",
-    )
-    p.add_argument(
-        "--key",
-        required=True,
-        help="Base64-encoded Ed25519 private key",
-    )
+    p.add_argument("--cid", required=True, help="IPFS CID")
+    p.add_argument("--app", required=True, help="Application name on the server")
+    p.add_argument("--url", required=True, help="Deploy service URL")
+    p.add_argument("--key", required=True, help="Base64-encoded Ed25519 private key")
     return p
 
 
 def main(argv: list[str] | None = None) -> None:
     args = build_parser().parse_args(argv)
 
-    key_b64 = args.key
-
     try:
-        signing_key = SigningKey(base64.b64decode(key_b64))
+        signing_key = SigningKey(base64.b64decode(args.key))
     except Exception as exc:
         print("Invalid private key (must be base64-encoded)", file=sys.stderr)
-        raise SystemExit(1) from exc
+        sys.exit(1)
 
     payload: Dict[str, Any] = {"cid": args.cid, "app": args.app}
-
-    # Use separators to eliminate whitespace – the server verifies the raw bytes
     body: bytes = json.dumps(payload, separators=(",", ":")).encode()
 
     signature: bytes = signing_key.sign(body).signature
@@ -59,10 +39,20 @@ def main(argv: list[str] | None = None) -> None:
     }
 
     resp = requests.post(args.url, headers=headers, data=body, timeout=60)
+
+    # Fail the workflow on HTTP error codes
+    if not resp.ok:
+        print(f"HTTP {resp.status_code}: {resp.text}", file=sys.stderr)
+        sys.exit(1)
+
     try:
-        print(resp.json())
+        # JSON body
+        print(json.dumps(resp.json(), indent=2))
+        return
     except ValueError:
+        # Plain-text body
         print(resp.text)
+        return
 
 
 if __name__ == "__main__":