Skip to content

branch-4.0: [performance](exec) fix zone map in effective in column preidate #58728 #58856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
github-actions wants to merge 1 commit into
base: branch-4.0
Choose a base branch
from
Open

branch-4.0: [performance](exec) fix zone map in effective in column preidate #58728 #58856

github-actions wants to merge 1 commit into from
+4 −8

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2025

Cherry-picked from #58728

@github-actions github-actions bot requested a review from yiguolei as a code owner December 9, 2025 09:20
@Thearas
Copy link
Contributor

Thearas commented Dec 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 9, 2025
@dataroaring dataroaring reopened this Dec 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Dec 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

BE UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.17% (18344/34499)
Line Coverage 38.75% (168629/435131)
Region Coverage 33.52% (130413/389081)
Branch Coverage 34.42% (56247/163401)

@HappenLee @yiguolei
[performance](exec) fix zone map in effective in column preidate (#58728
4f5a92c 
)

### What problem does this PR solve?

When a page contains some NULL values, we set both the min value and its
associated flag to NULL for filtering purposes in IN and comparison
operations. In such cases, we can directly compare the min/max values to
determine whether the zone map is effective, without needing to handle
the scenario where the min value is NULL. However, if all values in the
page are NULL, the entire page can be directly filtered out.
@yiguolei yiguolei force-pushed the auto-pick-58728-branch-4.0 branch from fdea95e to 4f5a92c Compare January 20, 2026 01:54
@yiguolei
Copy link
Contributor

yiguolei commented Jan 20, 2026

run buildall

@doris-robot
Copy link

doris-robot commented Jan 20, 2026

BE UT Coverage Report

Increment line coverage 25.00% (1/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (18889/35830)
Line Coverage 35.82% (175294/489380)
Region Coverage 32.44% (135490/417619)
Branch Coverage 33.32% (58776/176398)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Thearas @hello-stephen @yiguolei @doris-robot @dataroaring @HappenLee