Skip to content

Commit 5f0adf8

Browse files
committed
fix: use KEYSTORE_TARGET_PATH
1 parent abd2d35 commit 5f0adf8

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

action.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ runs:
202202
shell: bash
203203

204204
- name: Determine Android sourceDir and appName
205-
if: ${{ !env.ARTIFACT_URL }}
205+
if: ${{ !env.ARTIFACT_URL || (env.ARTIFACT_URL && inputs.re-sign) }}
206206
run: |
207207
JSON_OUTPUT=$(npx rock config -p android) || (echo "$JSON_OUTPUT" && exit 1)
208208
echo "$JSON_OUTPUT" | jq -r '.project'
@@ -214,7 +214,7 @@ runs:
214214
working-directory: ${{ inputs.working-directory }}
215215

216216
- name: Decode and store keystore file
217-
if: ${{ !env.ARTIFACT_URL && inputs.sign }}
217+
if: ${{ (!env.ARTIFACT_URL && inputs.sign) || (env.ARTIFACT_URL && inputs.re-sign) }}
218218
run: |
219219
if [ -n "$APP_NAME" ]; then
220220
KEYSTORE_TARGET_PATH="$ANDROID_SOURCE_DIR/$APP_NAME/${{ inputs.keystore-path }}"
@@ -236,6 +236,7 @@ runs:
236236
echo "${{ inputs.keystore-base64 }}" | base64 --decode > "$KEYSTORE_TARGET_PATH"
237237
echo "Successfully copied keystore base64 to target path: $KEYSTORE_TARGET_PATH"
238238
fi
239+
echo "KEYSTORE_TARGET_PATH=$KEYSTORE_TARGET_PATH" >> $GITHUB_ENV
239240
shell: bash
240241
working-directory: ${{ inputs.working-directory }}
241242

@@ -269,11 +270,10 @@ runs:
269270
run: |
270271
npx rock sign:android "${{ env.ARTIFACT_PATH }}" \
271272
--build-jsbundle \
272-
--keystore "${{ inputs.keystore-file }}" \
273+
--keystore "$KEYSTORE_TARGET_PATH" \
273274
--keystore-password "${{ inputs.keystore-store-password }}" \
274275
--key-alias "${{ inputs.keystore-key-alias }}" \
275276
--key-password "${{ inputs.keystore-key-password }}"
276-
277277
shell: bash
278278
working-directory: ${{ inputs.working-directory }}
279279

@@ -344,10 +344,9 @@ runs:
344344
npx rock remote-cache delete --name ${{ env.ARTIFACT_NAME }} --all-but-latest --json
345345
shell: bash
346346

347-
- name: Clean Up Keystore and gradle properties (signed builds only)
348-
if: ${{ !env.ARTIFACT_URL && inputs.sign }}
347+
- name: Clean Up Keystore
348+
if: ${{ (!env.ARTIFACT_URL && inputs.sign) || (env.ARTIFACT_URL && inputs.re-sign) }}
349349
run: |
350-
rm $HOME/.gradle/gradle.properties
351350
if [ -n "$APP_NAME" ]; then
352351
rm "$ANDROID_SOURCE_DIR/$APP_NAME/${{ inputs.keystore-path }}"
353352
else
@@ -356,6 +355,13 @@ runs:
356355
shell: bash
357356
working-directory: ${{ inputs.working-directory }}
358357

358+
- name: Clean Up gradle properties (signed builds only)
359+
if: ${{ !env.ARTIFACT_URL && inputs.sign }}
360+
run: |
361+
rm $HOME/.gradle/gradle.properties
362+
shell: bash
363+
working-directory: ${{ inputs.working-directory }}
364+
359365
- name: Post Build
360366
if: ${{ github.event_name == 'pull_request' && inputs.comment-bot == 'true' }}
361367
uses: callstackincubator/android/.github/actions/rock-post-build@v3

0 commit comments

Comments
 (0)