Test Reporter fails on workflow_run

[snovak7]

I have two step

...
      - uses: actions/upload-artifact@v4
        if: success() || failure()
        with:
          name: test-results
          path: "**/test-results*.trx"
...

and

name: report
on:
  workflow_run:
    workflows: 
      - build
    types:
      - completed
permissions: 
  contents: read
  actions: read
  checks: write
jobs:
  report:
    runs-on: ubuntu-latest
    steps:
      - uses: dorny/test-reporter@v1
        with:
          artifact: test-results
          name: dotnet tests
          path: '**/test-results*.trx'
          reporter: dotnet-trx

trx file is successfully uploaded, inspecting the URL of test reporter action, it offers me to download the file, but the action fails

Report fails with error
HTTPError: Response code 400 (Authentication information is not given in the correct format. Check the value of Authorization header.)

Additional info: it worked, but after I bumped the version of the upload-artifacts (among other), somehow stopped working...

[abelbraaksma]

I noticed something similar. Here's one of my public repos where it goes wrong (with a similar config as you have): fsprojects/FSharp.Control.TaskSeq#209. I.e., it looks as if it is hanging, but it simply doesn't run anymore (there have not been any changes in the workflow config):

I suspect actions/upload-artifact@v3 being updated to actions/upload-artifact@v4 to be at the root of the issue. I'll try it with reverting that update and will report back.

EDIT, we are not alone in this, see this long thread: actions/upload-artifact#472

[abelbraaksma]

Yep, this confirms it. The new upload-artifacts@v4 either has bugs, or other changes, that prevents it from working with test-reporter@v1. I tested it here (fsprojects/FSharp.Control.TaskSeq#212) with v3, which "just works", after all PRs with v4 did not work:

[jozefizso]

Yes, this caused by different behavior in artifacts v4: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

[abelbraaksma]

@jozefizso are you aware of any way to fix this? Would it require bumping the major version here as well, or could it be made compatible with either?

[SapiensAnatis]

FYI I was able to make this work using a similar workflow_run setup by manually invoking the download-artifact action at v4:

on:
  workflow_run:
    workflows: ["test"]
    types:
      - completed

jobs:
  report:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - name: Download artifacts
        uses: actions/download-artifact@v4
        with:
          github-token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
          pattern: test-result-*
          merge-multiple: true
          run-id: ${{ github.event.workflow_run.id }}
      - name: Generate report
        uses: dorny/test-reporter@v1
        with:
          name: test report
          path: "*.trx"
          reporter: dotnet-trx

You have to generate your own secrets.PERSONAL_ACCESS_TOKEN for the download-artifact action to be able to download artifacts from outside its own workflow. (see: https://github.com/actions/download-artifact#download-artifacts-from-other-workflow-runs-or-repositories) The workflow to download from is specified using ${{ github.event.workflow_run.id }}

[fernandopasik]

The github token @SapiensAnatis mentions needs to have the permission actions:read on target repo.

@jozefizso @abelbraaksma Would this mean that the fix for this problem in the action will need a token as well?

[abelbraaksma]

@fernandopasik I'm not sure, but it might very well be? If you want me to test a fix (I assume you'd do that in a new version as it'll introduce an incompatibility, I guess), let me know and I can run a test through fsprojects/FSharp.Control.TaskSeq#245).