Remove GPUI-related code from notification crate #3277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for howto-fix-macos-audio-selection canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes all GPUI-related code from the repository as requested. This includes:
crates/notification-gpuidirectory (toast UI implementation using GPUI framework)newfeature flag fromcrates/notification/Cargo.tomlthat enabled GPUI notifications#[cfg(feature = "new")]conditional blocks fromcrates/notification/src/lib.rsThe
notificationcrate now only supports thelegacyfeature (default), which uses platform-specific implementations (notification-macosandnotification-linux).Review & Testing Checklist for Human
newfeature flag or depending onnotification-gpuilegacyfeature should continue working)Notes
Lint check (dprint) timed out during plugin download, so formatting wasn't verified locally. CI should catch any formatting issues.
Link to Devin run: https://app.devin.ai/sessions/39c7ef1a3d5e4e4d83cb0a68b9bb7e44
Requested by: @yujonglee