Only build docstrings in the string renderer when there is content

Author: ghickman

src/classify/renderers/string.py

@@ -1,36 +1,44 @@
 from ..library import Class
 
 
-def to_string(structure: Class) -> str:
-    indent = " " * 4
-
-    def attributes(attributes):
-        attrs = []
-        for name, definitions in attributes.items():
-            value = definitions[-1].value
-            attrs.append(f"{indent}{name} = {value}\n")
-        return "".join(attrs)
-
-    def declaration(name, parents):
-        parents = ", ".join([p.__name__ for p in parents])
-        return f"class {name}({parents}):"
-
-    def docstring(docstring):
-        quotes = f'{indent}"""\n'
-        lines = docstring.split("\n")
-        block = "".join([f"{indent}{line}\n" for line in lines])
-        return f"{quotes}{block}{quotes}"
-
-    def methods(methods):
-        content = ""
-        for definitions in methods.values():
-            for d in definitions:
-                lines = d.code.split("\n")[:-1]
-                for line in lines:
-                    content += f"{indent}{line[4:]}\n"
-                content += "\n"
-        return content
+indent = " " * 4
+
+
+def attributes(attributes):
+    attrs = []
+    for name, definitions in attributes.items():
+        value = definitions[-1].value
+        attrs.append(f"{indent}{name} = {value}\n")
+    return "".join(attrs)
+
+
+def declaration(name, parents):
+    parents = ", ".join([p.__name__ for p in parents])
+    return f"class {name}({parents}):"
+
+
+def docstring(docstring):
+    if not docstring:
+        return ""
 
+    quotes = f'{indent}"""\n'
+    lines = docstring.split("\n")
+    block = "".join([f"{indent}{line}\n" for line in lines])
+    return f"{quotes}{block}{quotes}"
+
+
+def methods(methods):
+    content = ""
+    for definitions in methods.values():
+        for d in definitions:
+            lines = d.code.split("\n")[:-1]
+            for line in lines:
+                content += f"{indent}{line[4:]}\n"
+            content += "\n"
+    return content
+
+
+def to_string(structure: Class) -> str:
     content = declaration(structure.name, structure.parents)
     content += "\n"
     content += docstring(structure.docstring) if docstring else ""

tests/renderers/test_string.py

@@ -0,0 +1,5 @@
+from classify.renderers.string import docstring
+
+
+def test_docstring():
+    assert docstring("") == ""

tests/test_library.py

@@ -13,12 +13,15 @@
             DummyClass,
             [
                 "__init__",
+                "class_method",
+                "class_only_method",
                 "four",
                 "my_cached_prop",
                 "my_dj_cached_prop",
                 "my_property",
                 "one",
                 "some_attribute",
+                "static_method",
                 "two",
             ],
         ),