f

CHROME_STDLIB_MANUAL_ROLL=f

Author: sashwinbalaji

ui/src/core/load_trace.ts

@@ -525,7 +525,7 @@ async function getTraceInfo(
     (await engine.query(`select * from ftrace_event limit 1`)).numRows() > 0;
 
   const uuidRes = await engine.query(`select str_value as uuid from metadata
-    where name = 'trace_uuid'`);
+    where name = 'trace_uuid' limit 1`);
   // trace_uuid can be missing from the TP tables if the trace is empty or in
   // other similar edge cases.
   const uuid = uuidRes.numRows() > 0 ? uuidRes.firstRow({uuid: STR}).uuid : '';
@@ -555,7 +555,7 @@ async function getTraceInfo(
 
 async function getTraceType(engine: Engine) {
   const result = await engine.query(
-    `select str_value from metadata where name = 'trace_type'`,
+    `select str_value from metadata where name = 'trace_type' limit 1`,
   );
 
   if (result.numRows() === 0) return undefined;

ui/src/plugins/com.android.AndroidPerfTraceCounters/index.ts

@@ -24,6 +24,7 @@ const PERF_TRACE_COUNTERS_PRECONDITION = `
   WHERE
     name = 'trace_config_pbtxt'
     AND str_value GLOB '*ftrace_events: "perf_trace_counters/sched_switch_with_ctrs"*'
+  LIMIT 1
 `;
 
 export default class implements PerfettoPlugin {

ui/src/plugins/com.android.WearLongBatteryTracing/index.ts

@@ -213,7 +213,7 @@ export default class WearLongBatteryTracingPlugin implements PerfettoPlugin {
    */
   async onTraceLoad(ctx: Trace): Promise<void> {
     const result = await ctx.engine.query(
-      `SELECT int_value FROM metadata WHERE name = 'statsd_triggering_subscription_id'`,
+      `SELECT int_value FROM metadata WHERE name = 'statsd_triggering_subscription_id' limit 1`,
     );
     const row = result.maybeFirstRow({int_value: LONG});
     if (!row) {

ui/src/plugins/dev.perfetto.ProcessSummary/index.ts

@@ -84,9 +84,9 @@ export default class implements PerfettoPlugin {
           android_process_metadata.debuggable as isDebuggable,
           case
             when process.name = 'system_server' then
-              ifnull((select int_value from metadata where name = 'android_profile_system_server'), 0)
+              ifnull((select int_value from metadata where name = 'android_profile_system_server' limit 1), 0)
             when process.name GLOB 'zygote*' then
-              ifnull((select int_value from metadata where name = 'android_profile_boot_classpath'), 0)
+              ifnull((select int_value from metadata where name = 'android_profile_boot_classpath' limit 1), 0)
             else 0
           end as isBootImageProfiling,
           ifnull((

ui/src/plugins/dev.perfetto.TraceInfoPage/tabs/import_errors.ts

@@ -85,6 +85,11 @@ export async function loadImportErrorsData(
     logs: [] as ImportLogRow[],
   }));
 
+  const categoryMap = new Map<string, ErrorCategory>();
+  for (const category of categories) {
+    categoryMap.set(category.name, category);
+  }
+
   // Load import logs for each category
   const logsResult = await engine.query(`
     select
@@ -100,7 +105,7 @@ export async function loadImportErrorsData(
   `);
 
   for (const iter = logsResult.iter(importLogSpec); iter.valid(); iter.next()) {
-    const category = categories.find((c) => c.name === iter.name);
+    const category = categoryMap.get(iter.name);
     if (!category) continue;
 
     const traceId = iter.trace_id;

ui/src/plugins/org.kernel.Wattson/warning.ts

@@ -39,7 +39,8 @@ export async function hasWattsonSufficientCPUConfigs(
   const query = `
     SELECT str_value
     FROM metadata
-    WHERE name = 'trace_config_pbtxt';
+    WHERE name = 'trace_config_pbtxt'
+    LIMIT 1;
     `;
 
   const result = await engine.query(query);