Closing ResultSet

[flaffyyeti]

What about closing result set when stream is processed?
I don't see it is closed in JdbcStream, so shall it be handled by invoker?

[juliomarcopineda]

Hello, I think closing the result set has to be handled outside of JdbcStream.

My intent with this is class is to purely handle the conversion from JDBC ResultSet to a Stream object so anyone can easily use the Java Stream API (or even StreamEx). Any connection management to the SQL database is left to the user.

So for example, you could use a try-with-resources to call the close() method of ResultSet automatically:

// Set up connection and prepared statement

try (ResultSet resultSet = preparedStatement.executeQuery()) {
    long count = JdbcStream.stream(resultSet).count()
    System.out.println(count)
}

I think this is for the best so that the user has the most flexibility handling the connections to the SQL database.

[flaffyyeti]

I think in your example resultSet won't be closed by default, you need add handler for Stream.onClose with logic that will close the ResultSet