Add JET comments

Author: odow

src/Bridges/Constraint/bridges/IntegerToZeroOneBridge.jl

@@ -152,6 +152,7 @@ function MOI.Bridges.final_touch(
     bridge::IntegerToZeroOneBridge{T},
     model::MOI.ModelLike,
 ) where {T}
+    # Type annotation needed for JET
     ret = MOI.Utilities.get_bounds(model, T, bridge.x)::Tuple{T,T}
     if ret === bridge.last_bounds
         return nothing  # final_touch already called

src/FileFormats/LP/read.jl

@@ -511,6 +511,11 @@ end
 
 _is_number(c::Char) = isdigit(c) || c in ('.', 'e', 'E', '+', '-')
 
+function _is_negative_digit(state, c)
+    # The type annotation is needed for JET.
+    return c == '-' && isdigit(peek(state, Char)::Char)
+end
+
 function _peek_inner(state::_LexerState)
     while (c = peek(state, Char)) !== nothing
         pos = position(state.io)
@@ -523,7 +528,7 @@ function _peek_inner(state::_LexerState)
             while (c = peek(state, Char)) !== nothing && c != '\n'
                 _ = read(state, Char)
             end
-        elseif isdigit(c) || (c == '-' && isdigit(peek(state, Char)::Char)) # Number
+        elseif isdigit(c) || _is_negative_digit(state, c) # Number
             buf = IOBuffer()
             while (c = peek(state, Char)) !== nothing && _is_number(c)
                 write(buf, c)
@@ -826,6 +831,7 @@ function _parse_term(
         # <quadratic-expression>
         return _parse_quadratic_expression(state, cache, prefix)
     end
+    # The type annotation is needed for JET.
     token = peek(state, _Token)::_Token
     return _throw_parse_error(
         state,
@@ -1050,6 +1056,7 @@ function _parse_constraint_sos(
     f, w = MOI.VectorOfVariables(MOI.VariableIndex[]), T[]
     while true
         if _next_token_is(state, _TOKEN_NEWLINE)
+            # The type annotation is needed for JET.
             t = peek(state, _Token)::_Token
             _throw_parse_error(
                 state,
@@ -1096,6 +1103,7 @@ function _parse_constraint_indicator(
     end
     _ = read(state, _Token, _TOKEN_IMPLIES)
     f = _parse_expression(state, cache)
+    # The type annotation is needed for JET.
     set = _parse_set_suffix(state, cache)::MOI.AbstractScalarSet
     return MOI.add_constraint(
         cache.model,
@@ -1117,6 +1125,7 @@ function _parse_constraint(state::_LexerState, cache::_ReadCache)
         _parse_constraint_indicator(state, cache)
     else
         f = _parse_expression(state, cache)
+        # The type annotation is needed for JET.
         set = _parse_set_suffix(state, cache)::MOI.AbstractScalarSet
         MOI.add_constraint(cache.model, f, set)
     end

src/FileFormats/MPS/read.jl

@@ -432,6 +432,7 @@ function _add_indicator_constraint(
         scalar = MOI.ScalarAffineTerm(coef, variable_map[data.col_to_name[i]])
         push!(terms, MOI.VectorAffineTerm(2, scalar))
     end
+    # The type annotation is needed for JET.
     f = MOI.VectorAffineFunction(terms, zeros(T, 2)::Vector{T})
     c = MOI.add_constraint(model, f, MOI.Indicator{activate}(set))
     MOI.set(model, MOI.ConstraintName(), c, c_name)

src/FileFormats/NL/read.jl

@@ -271,12 +271,14 @@ _try_scalar_affine_function(x::MOI.VariableIndex) = x
 function _try_scalar_affine_function(expr::Expr)
     if expr.args[1] == :+
         args = _try_scalar_affine_function.(expr.args[2:end])
+        # The type annotation is needed for JET.
         if any(isnothing, args)::Bool
             return nothing
         end
         return MOI.Utilities.operate(+, Float64, args...)
     elseif expr.args[1] == :*
         args = _try_scalar_affine_function.(expr.args[2:end])
+        # The type annotation is needed for JET.
         if any(isnothing, args)::Bool
             return nothing
         end

src/Nonlinear/SymbolicAD/SymbolicAD.jl

@@ -1335,6 +1335,7 @@ function Evaluator(
     if model.objective !== nothing
         o_sym = _to_symbolic_form(
             model,
+            # The type annotation is needed for JET.
             model.objective::MOI.Nonlinear.Expression,
             variable_to_column,
         )

src/Test/test_conic.jl

@@ -2175,6 +2175,7 @@ function _test_conic_RotatedSecondOrderCone_helper(
             MOI.RotatedSecondOrderCone,
         )
     end
+    # These variables are needed for JET.
     vc1, vc2 = nothing, nothing
     if abvars
         abx, rsoc =
@@ -5939,6 +5940,7 @@ function _test_det_cone_helper_ellipsoid(
     @test MOI.get(model, MOI.NumberOfVariables()) == 1
     Q = MOI.add_variables(model, square ? 4 : 3)
     @test MOI.get(model, MOI.NumberOfVariables()) == (square ? 5 : 4)
+    # These variables are needed for JET.
     u, vc = nothing, nothing
     if use_logdet
         u = MOI.add_variable(model)

src/Utilities/distance_to_set.jl

@@ -509,6 +509,7 @@ function _reshape(
     set::MOI.PositiveSemidefiniteConeTriangle,
 ) where {T}
     n = MOI.side_dimension(set)
+    # The type annotation is needed for JET.
     X = zeros(T, n, n)::Matrix{T}
     k = 1
     for i in 1:n

src/Utilities/model.jl

@@ -295,6 +295,7 @@ function MOI.get(model::AbstractModel, ::Type{MOI.VariableIndex}, name::String)
     if model.name_to_var === nothing
         model.name_to_var = build_name_to_var_map(model.var_to_name)
     end
+    # The type annotation is needed for JET.
     result =
         get(model.name_to_var::Dict{String,MOI.VariableIndex}, name, nothing)
     throw_if_multiple_with_name(result, name)