why is nur a part of this flake?

[DrTeagle]

Howdy, as title I was wondering why we depend on NUR?
AFAIK depending on NUR will copy all of NUR code to the users nix-store. Please correct me if I am wrong. if NUR is needed perhaps we can do what std did and make it a blank flake that needs to be overriden(with checks)?

[danth]

It's only used to install the Firefox Color addon:

stylix/modules/firefox/each-config.nix

Line 104 in 647bb8d

packages = [ firefox-addons.firefox-color ];

Potentially we could depend on Rycee's repository directly. This would reduce the size of flake dependencies without removing any functionality.

[danth]

Created #1963

[0xda157]

AFAIK depending on NUR will copy all of NUR code to the users nix-store. Please correct me if I am wrong. if NUR is needed perhaps we can do what std did and make it a blank flake that needs to be overriden(with checks)?

It copies https://github.com/nix-community/nur to the store, but that doesn't contain the source for all nur derivations, only a list of all nur repos which get lazied downloaded. This is a relativity small overhead and I would prefer to just use the primary nur input to minimize changes our (public) flake inputs.

[trueNAHO]

Following the discussion in #1963, we will keep the negligibly small NUR dependency.