Skip to content

Commit be30e0c

Browse files
zeitlingertrask
andauthored
Migrate InstrumentationModule to declarative config API (#15792)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent 0d1bd58 commit be30e0c

File tree

22 files changed

+49
-51
lines changed

22 files changed

+49
-51
lines changed

instrumentation/dropwizard/dropwizard-metrics-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/dropwizardmetrics/DropwizardMetricsInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1515
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
16-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1716
import java.util.List;
1817
import net.bytebuddy.matcher.ElementMatcher;
1918

@@ -32,7 +31,7 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
3231
}
3332

3433
@Override
35-
public boolean defaultEnabled(ConfigProperties config) {
34+
public boolean defaultEnabled() {
3635
// the Dropwizard metrics API does not have a concept of metric labels/tags/attributes, thus the
3736
// data produced by this integration might be of very low quality, depending on how the API is
3837
// used in the instrumented application

instrumentation/internal/internal-application-logger/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/logging/ApplicationLoggingInstrumentationModule.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1313
import io.opentelemetry.javaagent.tooling.config.EarlyInitAgentConfig;
14-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1514
import java.util.List;
1615

1716
@AutoService(InstrumentationModule.class)
@@ -22,10 +21,9 @@ public ApplicationLoggingInstrumentationModule() {
2221
}
2322

2423
@Override
25-
public boolean defaultEnabled(ConfigProperties config) {
24+
public boolean defaultEnabled() {
2625
// only enable this instrumentation if the application logger is enabled
27-
return super.defaultEnabled(config)
28-
&& "application".equals(EarlyInitAgentConfig.get().getLogging());
26+
return super.defaultEnabled() && "application".equals(EarlyInitAgentConfig.get().getLogging());
2927
}
3028

3129
@Override

instrumentation/internal/internal-class-loader/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/classloader/ClassLoaderInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1313
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
14-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1514
import java.util.List;
1615

1716
@AutoService(InstrumentationModule.class)
@@ -22,7 +21,7 @@ public ClassLoaderInstrumentationModule() {
2221
}
2322

2423
@Override
25-
public boolean defaultEnabled(ConfigProperties config) {
24+
public boolean defaultEnabled() {
2625
// internal instrumentations are always enabled by default
2726
return true;
2827
}

instrumentation/internal/internal-eclipse-osgi-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/osgi/EclipseOsgiInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1313
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
14-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1514
import java.util.List;
1615

1716
@AutoService(InstrumentationModule.class)
@@ -22,7 +21,7 @@ public EclipseOsgiInstrumentationModule() {
2221
}
2322

2423
@Override
25-
public boolean defaultEnabled(ConfigProperties config) {
24+
public boolean defaultEnabled() {
2625
// internal instrumentations are always enabled by default
2726
return true;
2827
}

instrumentation/internal/internal-lambda/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/lambda/LambdaInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1313
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
14-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1514
import java.util.Collections;
1615
import java.util.List;
1716

@@ -23,7 +22,7 @@ public LambdaInstrumentationModule() {
2322
}
2423

2524
@Override
26-
public boolean defaultEnabled(ConfigProperties config) {
25+
public boolean defaultEnabled() {
2726
// internal instrumentations are always enabled by default
2827
return true;
2928
}

instrumentation/internal/internal-reflection/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/reflection/ReflectionInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.ClassInjector;
1515
import io.opentelemetry.javaagent.extension.instrumentation.internal.injection.InjectionMode;
16-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1716
import java.util.List;
1817

1918
@AutoService(InstrumentationModule.class)
@@ -24,7 +23,7 @@ public ReflectionInstrumentationModule() {
2423
}
2524

2625
@Override
27-
public boolean defaultEnabled(ConfigProperties config) {
26+
public boolean defaultEnabled() {
2827
// internal instrumentations are always enabled by default
2928
return true;
3029
}

instrumentation/internal/internal-url-class-loader/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/urlclassloader/UrlClassLoaderInstrumentationModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.google.auto.service.AutoService;
1111
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1212
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
13-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1413
import java.util.List;
1514

1615
@AutoService(InstrumentationModule.class)
@@ -20,7 +19,7 @@ public UrlClassLoaderInstrumentationModule() {
2019
}
2120

2221
@Override
23-
public boolean defaultEnabled(ConfigProperties config) {
22+
public boolean defaultEnabled() {
2423
// internal instrumentations are always enabled by default
2524
return true;
2625
}

instrumentation/jaxrs/jaxrs-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v1_0/JaxrsInstrumentationModule.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1515
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1616
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
17-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1817
import java.util.List;
1918
import net.bytebuddy.matcher.ElementMatcher;
2019

@@ -37,11 +36,11 @@ public List<TypeInstrumentation> typeInstrumentations() {
3736
}
3837

3938
@Override
40-
public boolean defaultEnabled(ConfigProperties config) {
39+
public boolean defaultEnabled() {
4140
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4241
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4342
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
44-
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
43+
return super.defaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
4544
}
4645

4746
@Override

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/JaxrsAnnotationsInstrumentationModule.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1515
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
16-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1716
import java.util.List;
1817
import net.bytebuddy.matcher.ElementMatcher;
1918

@@ -40,11 +39,11 @@ public List<TypeInstrumentation> typeInstrumentations() {
4039
}
4140

4241
@Override
43-
public boolean defaultEnabled(ConfigProperties config) {
42+
public boolean defaultEnabled() {
4443
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4544
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4645
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
47-
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
46+
return super.defaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
4847
}
4948

5049
@Override

instrumentation/jaxrs/jaxrs-3.0/jaxrs-3.0-annotations/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v3_0/JaxrsAnnotationsInstrumentationModule.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1515
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
16-
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1716
import java.util.List;
1817
import net.bytebuddy.matcher.ElementMatcher;
1918

@@ -40,11 +39,11 @@ public List<TypeInstrumentation> typeInstrumentations() {
4039
}
4140

4241
@Override
43-
public boolean defaultEnabled(ConfigProperties config) {
42+
public boolean defaultEnabled() {
4443
// This instrumentation produces controller telemetry and sets http route. Http route is set by
4544
// this instrumentation only when it was not already set by a jax-rs framework instrumentation.
4645
// This instrumentation uses complex type matcher, disabling it can improve startup performance.
47-
return super.defaultEnabled(config) && ExperimentalConfig.get().controllerTelemetryEnabled();
46+
return super.defaultEnabled() && ExperimentalConfig.get().controllerTelemetryEnabled();
4847
}
4948

5049
@Override

0 commit comments

Comments
 (0)