Fix problems with spaces in search paths, clean up

Author: timothyschoen

Source/Heavy/DPFExporter.h

@@ -211,18 +211,17 @@ class DPFExporter final : public ExporterBase {
         args.add("-v");
         args.add("-gdpf");
 
-        String paths = "-p";
+        args.add("-p");
         for (auto& path : searchPaths) {
-            paths += " " + path;
+            args.add(path);
         }
 
-        args.add(paths);
-
         if (shouldQuit)
             return true;
 
-        exportingView->logToConsole("Command: " + args.joinIntoString(" ") + "\n");
-        start(args);
+        auto const command = args.joinIntoString(" ");
+        exportingView->logToConsole("Command: " + command + "\n");
+        Toolchain::startShellScript(command, this);
 
         waitForProcessToFinish(-1);
         exportingView->flushConsole();

Source/Heavy/DaisyExporter.h

@@ -249,8 +249,8 @@ class DaisyExporter final : public ExporterBase {
         auto size = getValue<int>(patchSizeValue);
         auto appType = getValue<int>(appTypeValue);
 
-        
-        StringArray args = { heavyExecutable.getFullPathName(), pdPatch, "-o", outdir};
+
+        StringArray args = { heavyExecutable.getFullPathName(), pdPatch, "-o", outdir.quoted()};
 
         name = name.replaceCharacter('-', '_');
         args.add("-n" + name);
@@ -337,15 +337,14 @@ class DaisyExporter final : public ExporterBase {
         args.add("-v");
         args.add("-gdaisy");
 
-        String paths = "-p";
+        args.add("-p");
         for (auto& path : searchPaths) {
-            paths += " " + path;
+            args.add(path);
         }
 
-        args.add(paths);
-
-        exportingView->logToConsole("Command: " + args.joinIntoString(" ") + "\n");
-        start(args);
+        auto const command = args.joinIntoString(" ");
+        exportingView->logToConsole("Command: " + command + "\n");
+        Toolchain::startShellScript(command, this);
         waitForProcessToFinish(-1);
         exportingView->flushConsole();
 

Source/Heavy/ExporterBase.h

@@ -143,7 +143,11 @@ struct ExporterBase : public Component
         auto searchPaths = StringArray {};
         if (realPatchFile.existsAsFile() && !realPatchFile.isRoot())
         {
+#if JUCE_WINDOWS
             searchPaths.add(realPatchFile.getParentDirectory().getFullPathName().replaceCharacter('\\', '/').quoted());
+#else
+            searchPaths.add(realPatchFile.getParentDirectory().getFullPathName().quoted());
+#endif
         }
         editor->pd->setThis();
 

Source/Heavy/OWLExporter.h

@@ -107,13 +107,11 @@ class OWLExporter : public ExporterBase {
         args.add("-v");
         args.add("-gOWL");
 
-        String paths = "-p";
+        args.add("-p");
         for (auto& path : searchPaths) {
-            paths += " " + path;
+            args.add(path);
         }
 
-        args.add(paths);
-
         exportingView->logToConsole("Command: " + args.joinIntoString(" ") + "\n");
         start(args);
 

Source/Heavy/PdExporter.h

@@ -78,18 +78,17 @@ class PdExporter final : public ExporterBase {
         args.add("-v");
         args.add("-gpdext");
 
-        String paths = "-p";
+        args.add("-p");
         for (auto& path : searchPaths) {
-            paths += " " + path;
+            args.add(path);
         }
 
-        args.add(paths);
-
         if (shouldQuit)
             return true;
 
-        exportingView->logToConsole("Command: " + args.joinIntoString(" ") + "\n");
-        start(args);
+        auto const command = args.joinIntoString(" ");
+        exportingView->logToConsole("Command: " + command + "\n");
+        Toolchain::startShellScript(command, this);
 
         waitForProcessToFinish(-1);
         exportingView->flushConsole();

Source/Heavy/WASMExporter.h

@@ -81,17 +81,11 @@ class WASMExporter : public ExporterBase {
         args.add("-v");
         args.add("-gjs");
 
-        String paths = "-p";
+        args.add("-p");
         for (auto& path : searchPaths) {
-#if JUCE_WINDOWS
-            paths += " " + path.replaceCharacter('\\', '/');
-#else
-            paths += " " + path;
-#endif
+            args.add(path);
         }
 
-        args.add(paths);
-
         if (shouldQuit)
             return true;