warning: this `if` statement can be collapsed --> cosmic-app-list/src/wayland_handler.rs:627:25 | 627 | / if let Some(cosmic_toplevel) = state.cosmic_toplevel(&handle) { 628 | | if let Some(seat) = state.seat_state.seats().next() { 629 | | let manager = &state.toplevel_manager_state.manager; 630 | | manager.activate(&cosmic_toplevel, &seat); 631 | | } 632 | | } | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 627 ~ if let Some(cosmic_toplevel) = state.cosmic_toplevel(&handle) 628 ~ && let Some(seat) = state.seat_state.seats().next() { 629 | let manager = &state.toplevel_manager_state.manager; 630 | manager.activate(&cosmic_toplevel, &seat); 631 ~ } |

warning: this `if` statement can be collapsed --> cosmic-app-list/src/app.rs:1189:17 | 1189 | / if let Some(DndOffer { dock_item, .. }) = self.dnd_offer.as_mut() { 1190 | | if let Ok(de) = fde::DesktopEntry::from_path(file_path.0, Some(&self.locales)) { 1191 | | self.item_ctr += 1; 1192 | | *dock_item = Some(DockItem { ... | 1199 | | } | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if help: collapse nested if block | 1189 ~ if let Some(DndOffer { dock_item, .. }) = self.dnd_offer.as_mut() 1190 ~ && let Ok(de) = fde::DesktopEntry::from_path(file_path.0, Some(&self.locales)) { 1191 | self.item_ctr += 1; ... 1197 | }); 1198 ~ } |

warning: this `if` statement can be collapsed --> cosmic-app-list/src/app.rs:1099:21 | 1099 | / if self.dnd_offer.take().is_some() { 1100 | | if let Some((_, toplevel_group, _, pinned_pos)) = self.dnd_source.as_ref() { 1101 | | let mut pos = 0; 1102 | | self.pinned_list.retain_mut(|pinned| { ... | 1113 | | } | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 1099 ~ if self.dnd_offer.take().is_some() 1100 ~ && let Some((_, toplevel_group, _, pinned_pos)) = self.dnd_source.as_ref() { 1101 | let mut pos = 0; ... 1111 | }); 1112 ~ } |

warning: large size difference between variants --> cosmic-app-list/src/app.rs:373:1 | 373 | / enum Message { 374 | | Wayland(WaylandUpdate), | | ---------------------- the largest variant contains at least 400 bytes 375 | | PinApp(u32), 376 | | UnpinApp(u32), ... | 380 | | ToplevelHoverChanged(ExtForeignToplevelHandleV1, bool), | | ------------------------------------------------------ the second-largest variant contains at least 65 bytes ... | 405 | | Surface(surface::Action), 406 | | } | |_^ the entire enum is at least 400 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum | 374 - Wayland(WaylandUpdate), 374 + Wayland(Box<WaylandUpdate>), |

warning: this function has too many arguments (9/7) --> cosmic-app-list/src/app.rs:175:5 | 175 | / fn as_icon( 176 | | &self, 177 | | applet: &Context, 178 | | rectangle_tracker: Option<&RectangleTracker<DockItemId>>, ... | 184 | | window_id: window::Id, 185 | | ) -> Element<'_, Message> { | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: variants `StartListeningForDnd` and `StopListeningForDnd` are never constructed --> cosmic-app-list/src/app.rs:399:5 | 373 | enum Message { | ------- variants in this enum ... 399 | StartListeningForDnd, | ^^^^^^^^^^^^^^^^^^^^ 400 | StopListeningForDnd, | ^^^^^^^^^^^^^^^^^^^ | = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: unused import: `channel::mpsc::TrySendError` --> cosmic-applet-network/src/app.rs:48:26 | 48 | use futures::{StreamExt, channel::mpsc::TrySendError}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused imports: `NmState` and `access_point` --> cosmic-applet-network/src/app.rs:43:5 | 43 | access_point, | ^^^^^^^^^^^^ 44 | enums::{ActiveConnectionState, DeviceState, NmConnectivityState, NmState}, | ^^^^^^^

warning: unused import: `time::Duration` --> cosmic-applet-network/src/app.rs:18:5 | 18 | time::Duration, | ^^^^^^^^^^^^^^