Duplicate reject reason constant value (5) in errors.go

[YoussefOuirini]

Description

I noticed that the errors.go file defines two constants with the same value 5:

rejectReasonValueIsIncorrect                  = 5
rejectReasonConditionallyRequiredFieldMissing = 5

This creates ambiguity when interpreting reject reason codes, especially in logs or downstream processing.

Reference

According to the FIX 4.4 specification (Tag 373 – SessionRejectReason):

5 = Value is incorrect (out of range) for this tag

8 = Conditionally required field missing

Therefore, it seems like rejectReasonConditionallyRequiredFieldMissing should be assigned the value 8 instead of 5.

Suggested Fix

Update the constant to:

rejectReasonConditionallyRequiredFieldMissing = 8

[vyourtchenko-connamara]

This file references another field for its rejectReason which happens to be BusinessRejectReason.

380 BusinessRejectReason
5 = Conditionally Required Field Missing [ConditionallyRequiredFieldMissing]

This would explain why there's a duplicate enum. However that doesn't warrant changing the code because of how that's handled below.

// ConditionallyRequiredFieldMissing indicates that the requested field could not be found in the FIX message. func ConditionallyRequiredFieldMissing(tag Tag) MessageRejectError { return NewBusinessMessageRejectError(fmt.Sprintf("Conditionally Required Field Missing (%d)", tag), rejectReasonConditionallyRequiredFieldMissing, &tag) }

So it returns either NewMessageRejectError (rejectReasonValueIsIncorrect) or NewBusinessMessageRejectError (rejectReasonConditionallyRequiredFieldMissing) depending on the context