WIP: high-level integration test for legacy promotion system

Co-authored-by: Jared Norman <jared@super.gd>
Co-authored-by: Kendra Riga <kendra@super.gd>
Co-authored-by: Adam Mueller <adam@super.gd>
Co-authored-by: Alistair Norman <alistair@super.gd>
Co-authored-by: Senem Soy <senem@super.gd>
Co-authored-by: Sofia Besenski <sofia@super.gd>

Author: 7 people

legacy_promotions/app/patches/models/solidus_legacy_promotions/spree_order_updater_patch.rb

@@ -41,6 +41,8 @@ def update_item_totals
         )
       end
     end
-    Spree::OrderUpdater.prepend self
+
+    # FIXME: We need to verify that this is the right thing to do?
+    Spree::Config.order_recalculator_class.prepend self
   end
 end

legacy_promotions/spec/models/spree/promotion_integration_spec.rb

@@ -232,23 +232,72 @@
         order.complete
       }.to change{ promo_adjustment.reload.eligible }.to(false)
     end
+  end
 
-    it "adjusts the promo_total" do
-      expect{
-        order.complete
-      }.to change(order, :promo_total).by(10)
+  describe "checking whether a promotion code is still eligible after one use" do
+    let(:promotion) do
+      FactoryBot.create(
+        :promotion,
+        :with_order_adjustment,
+        code: "discount",
+        per_code_usage_limit: 1,
+        weighted_order_adjustment_amount: 10
+      )
+    end
+    let(:code) { promotion.codes.first }
+    let(:order) do
+      FactoryBot.create(:order_with_line_items, line_items_price: 40, shipment_cost: 0).tap do |order|
+        FactoryBot.create(:payment, amount: 30, order:)
+        promotion.activate(order:, promotion_code: code)
+      end
     end
+    let(:promo_adjustment) { order.adjustments.promotion.first }
 
-    it "increases the total to remove the promo" do
-      expect{
-        order.complete
-      }.to change(order, :total).from(30).to(40)
+    before do
+      order.next! until order.can_complete?
+
+      FactoryBot.create(:order_with_line_items, line_items_price: 40, shipment_cost: 0).tap do |order|
+        FactoryBot.create(:payment, amount: 30, order:)
+        promotion.activate(order:, promotion_code: code)
+        order.next! until order.can_complete?
+        order.complete!
+      end
     end
 
-    it "resets the state of the order" do
-      expect{
-        order.complete
-      }.to change{ order.reload.state }.from("confirm").to("address")
+    context 'with the in-memory order updater' do
+      subject { order.recalculate(persist: false) }
+
+      around do |example|
+        default_order_recalculator = Spree::Config.order_recalculator_class.to_s
+
+        Spree::Config.order_recalculator_class = 'Spree::InMemoryOrderUpdater'
+
+        example.run
+
+        Spree::Config.order_recalculator_class = default_order_recalculator
+      end
+
+      it "makes the promotion ineligible" do
+        expect { subject }
+          .to change { order.adjustments.first.eligible }
+          .from(true)
+          .to(false)
+
+        expect(promo_adjustment.reload.eligible).to eq true
+      end
+
+      it "adjusts the promo_total" do
+        expect { subject }.to change { order.promo_total }.from(-10).to(0)
+
+        expect(order.reload.promo_total).to eq -10
+      end
+
+      it "increases the total to remove the promo",
+        pending: "This failure points to a real issue we have with the in-memory order updater" do
+        expect { subject }.to change { order.total }.from(30).to(40)
+
+        expect(order.reload.total).to eq 40
+      end
     end
   end