Merge pull request #94 from worksome/JIRA-16017_multi-line-array-shapes

fix: JIRA-16017 Resolve multi-line array shapes

Author: owenvoke

composer.json

@@ -13,7 +13,7 @@
         "rector/rector": "^2.0",
         "slevomat/coding-standard": "^8.16",
         "spaze/phpstan-disallowed-calls": "^4.4",
-        "symplify/easy-coding-standard": "^12.5"
+        "symplify/easy-coding-standard": "^12.6"
     },
     "require-dev": {
         "composer/composer": "^2.8",

src/PhpCsFixer/SpaceInGenericsFixer.php

@@ -9,6 +9,7 @@
 use PhpCsFixer\FixerDefinition\CodeSample;
 use PhpCsFixer\FixerDefinition\FixerDefinition;
 use PhpCsFixer\FixerDefinition\FixerDefinitionInterface;
+use PhpCsFixer\Preg;
 use PhpCsFixer\Tokenizer\Token;
 use PhpCsFixer\Tokenizer\Tokens;
 use SplFileInfo;
@@ -27,13 +28,7 @@ public function getDefinition(): FixerDefinitionInterface
 
     protected function fixType(string $type): string
     {
-        $newType = preg_replace('/\h*,\s*/', ', ', $type);
-
-        if ($newType === $type) {
-            return $type;
-        }
-
-        return $this->fixType($newType);
+        return Preg::replace('/,(?!\\R)\\s*/', ', ', Preg::replace('/\\h*,/', ',', $type));
     }
 
     public function fix(SplFileInfo $file, Tokens $tokens): void
@@ -50,13 +45,14 @@ public function fix(SplFileInfo $file, Tokens $tokens): void
                     continue;
                 }
 
-                $typeExpression = $annotation->getTypeExpression();
-                if ($typeExpression === null) {
+                $types = $annotation->getTypes();
+                if ($types === []) {
                     continue;
                 }
 
-                $type = $this->fixType($typeExpression->toString());
-                $annotation->setTypes([$type]);
+                $types = \array_map(fn (string $x): string => $this->fixType($x), $types);
+
+                $annotation->setTypes($types);
             }
 
             $newContent = $docBlock->getContent();

tests/PhpCsFixer/SpaceInGenericsFixerTest.php

@@ -83,4 +83,31 @@
                     * @return array<string,Foo> Description having "," should not be touched
                     */',
     ];
+
+    yield [
+        '<?php /**
+                    * Multi-line array shapes are supported.
+                    *
+                    * @param  array{
+                    *     extensions?: array<int, class-string<ExtensionInterface>|ExtensionInterface>,
+                    *     renderers?: array{
+                    *         fenced?: array<int, class-string<NodeRendererInterface>|NodeRendererInterface>,
+                    *         indented?: array<int, class-string<NodeRendererInterface>|NodeRendererInterface>
+                    *     },
+                    *     languages?: array<int, array{name: string, path: string, overwrite?: bool}>
+                    * }
+                    */',
+        '<?php /**
+                    * Multi-line array shapes are supported.
+                    *
+                    * @param  array{
+                    *     extensions?: array<int,class-string<ExtensionInterface>|ExtensionInterface>,
+                    *     renderers?: array{
+                    *         fenced?: array<int,class-string<NodeRendererInterface>|NodeRendererInterface>,
+                    *         indented?: array<int,class-string<NodeRendererInterface>|NodeRendererInterface>
+                    *     },
+                    *     languages?: array<int,array{name: string, path: string, overwrite?: bool}>
+                    * }
+                    */',
+    ];
 });