Rename extension method "AsEnumerable" to "AsDynamicEnumerable". (#642)

Author: StefH

src/System.Linq.Dynamic.Core/DynamicQueryableExtensions.cs

@@ -281,29 +281,29 @@ public static double Average(this IQueryable source, LambdaExpression lambda)
         }
         #endregion Average
 
-        #region AsEnumerable
+        #region AsDynamicEnumerable
 #if NET35
         /// <summary>
         /// Returns the input typed as <see cref="IEnumerable{T}"/> of <see cref="object"/>./>
         /// </summary>
         /// <param name="source">The sequence to type as <see cref="IEnumerable{T}"/> of <see cref="object"/>.</param>
         /// <returns>The input typed as <see cref="IEnumerable{T}"/> of <see cref="object"/>.</returns>
-        public static IEnumerable<object> AsEnumerable(this IQueryable source)
+        public static IEnumerable<object> AsDynamicEnumerable(this IQueryable source)
 #else
         /// <summary>
         /// Returns the input typed as <see cref="IEnumerable{T}"/> of dynamic.
         /// </summary>
         /// <param name="source">The sequence to type as <see cref="IEnumerable{T}"/> of dynamic.</param>
         /// <returns>The input typed as <see cref="IEnumerable{T}"/> of dynamic.</returns>
-        public static IEnumerable<dynamic> AsEnumerable(this IQueryable source)
+        public static IEnumerable<dynamic> AsDynamicEnumerable(this IQueryable source)
 #endif
         {
             foreach (var obj in source)
             {
                 yield return obj;
             }
         }
-        #endregion AsEnumerable
+        #endregion AsDynamicEnumerable
 
         #region Cast
         private static readonly MethodInfo _cast = QueryableMethodFinder.GetGenericMethod(nameof(Queryable.Cast));

test/System.Linq.Dynamic.Core.Tests/ComplexTests.cs

@@ -111,11 +111,11 @@ public void GroupByAndSelect_TestDynamicSelectMember()
 #else
             Assert.Equal(
                 realQry.Select(x => x.Age).ToArray(),
-                selectQry.AsEnumerable().Select(x => x.Age).Cast<int?>().ToArray());
+                selectQry.AsDynamicEnumerable().Select(x => x.Age).Cast<int?>().ToArray());
 
             Assert.Equal(
                 realQry.Select(x => x.TotalIncome).ToArray(),
-                selectQry.AsEnumerable().Select(x => x.TotalIncome).Cast<int>().ToArray());
+                selectQry.AsDynamicEnumerable().Select(x => x.TotalIncome).Cast<int>().ToArray());
 #endif
         }
     }

test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs

@@ -2180,7 +2180,7 @@ public void ExpressionTests_Sum()
             var qry = initValues.AsQueryable().Select(x => new { strValue = "str", intValue = x }).GroupBy(x => x.strValue);
 
             // Act
-            var result = qry.Select("Sum(intValue)").AsEnumerable().ToArray()[0];
+            var result = qry.Select("Sum(intValue)").AsDynamicEnumerable().ToArray()[0];
 
             // Assert
             Assert.Equal(15, result);
@@ -2194,7 +2194,7 @@ public void ExpressionTests_Sum_LowerCase()
             var qry = initValues.AsQueryable().Select(x => new { strValue = "str", intValue = x }).GroupBy(x => x.strValue);
 
             // Act
-            var result = qry.Select("sum(intValue)").AsEnumerable().ToArray()[0];
+            var result = qry.Select("sum(intValue)").AsDynamicEnumerable().ToArray()[0];
 
             // Assert
             Assert.Equal(15, result);

test/System.Linq.Dynamic.Core.Tests/QueryableTests.Select.cs

@@ -142,7 +142,7 @@ public void Select_Dynamic3()
             Assert.Equal(testList.Select(x => x.UserName).ToArray(), userNames.Cast<string>().ToArray());
             Assert.Equal(
                 testList.Select(x => "{ UserName = " + x.UserName + ", MyFirstName = " + x.Profile.FirstName + " }").ToArray(),
-                userFirstName.AsEnumerable().Select(x => x.ToString()).Cast<string>().ToArray());
+                userFirstName.AsDynamicEnumerable().Select(x => x.ToString()).Cast<string>().ToArray());
             Assert.Equal(testList[0].Roles.Select(x => x.Id).ToArray(), Enumerable.ToArray(userRoles.First().RoleIds));
 #endif
         }