[FEATURE] Modification de la taille de font sur les valeurs de la jauge en version small (PIX-17799) #876
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr876.review.pix.fr |
xav-car
reviewed
May 12, 2025
| font-weight: var(--pix-font-bold); | ||
|
|
||
| @extend %pix-body-s; | ||
| font-size: 0.875rem; |
Contributor
There was a problem hiding this comment.
le pix body s est déjà en 0.875 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
La font appliquée sur la version large est également sur la version small mais le rendu visuel n'est pas optimal
🎁 Proposition
Appliquer le token font body-s (0.875rem)
🌟 Remarques
Le token body-s semblait déjà être appliqué mais ne fonctionne pas, j'ai le souvenir qu'à l'époque de la construction du composant, il était question d'utiliser la propriété CSS en font-size directement.
🎅 Pour tester
Vérifier que la font est à 0.875rem en version small