-
Notifications
You must be signed in to change notification settings - Fork 852
Update Jetpack dashboard links to My Jetpack (MYJP-286) #46508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 3 files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f350636c5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <?php } ?> | ||
| </div> | ||
| <a class="jp-footer__a8c-logo" href="<?php echo esc_url( $jetpack_about_url ); ?>" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>"> | ||
| <a class="jp-footer__a8c-logo" href="<?php echo esc_url( Redirect::get_url( 'a8c-about' ) ); ?>" target="_blank" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add noopener to new-tab external logo link
This link now opens in a new tab (target="_blank") but omits rel="noopener noreferrer", so the external redirect page can access window.opener and potentially navigate the original admin page (reverse tabnabbing). This only matters when the redirect resolves to an external origin, but that’s exactly the case here. Please add rel="noopener noreferrer" to match the other external links in this footer.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured it's ok to skip it for automattic.com as it's trusted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates Jetpack dashboard links to redirect users to My Jetpack instead of the deprecated Jetpack dashboard. It simplifies the footer link logic by always using external redirects for About, Privacy, and Automattic links, removing the previous conditional behavior based on connection status.
Changes:
- Updated primary dashboard links from
admin.php?page=jetpacktoadmin.php?page=my-jetpack - Removed conditional logic for footer links, now consistently using external redirects
- Deprecated the
useInternalLinksprop in the JetpackFooter component while maintaining backwards compatibility
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/plugins/jetpack/changelog/copilot-update-dashboard-links-myjp-286 | Changelog entry documenting the bugfix for dashboard navigation links |
| projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php | Updated PHP footer and masthead to use My Jetpack links and external redirects consistently |
| projects/plugins/jetpack/_inc/client/components/masthead/index.jsx | Modified React masthead logo to link to My Jetpack using siteAdminUrl |
| projects/js-packages/components/components/jetpack-footer/index.tsx | Removed useInternalLinks logic, now always using external redirects for footer links |
| projects/js-packages/components/components/jetpack-footer/test/snapshots/component.tsx.snap | Updated snapshot to reflect new rel and target attributes on Automattic logo link |
| projects/js-packages/components/changelog/update-dashboard-links-myjp-286 | Changelog entry for the components package changes |
| <?php } ?> | ||
| </div> | ||
| <a class="jp-footer__a8c-logo" href="<?php echo esc_url( $jetpack_about_url ); ?>" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>"> | ||
| <a class="jp-footer__a8c-logo" href="<?php echo esc_url( Redirect::get_url( 'a8c-about' ) ); ?>" target="_blank" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>"> |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Automattic logo link is missing the rel="noreferrer" attribute. This attribute should be added for consistency with other external links in the footer and to prevent the Referer header from being sent to the external site. The TypeScript footer component includes this attribute (line 138 in jetpack-footer/index.tsx), and it should be consistent here as well.
Co-authored-by: haqadn <[email protected]>
Co-authored-by: haqadn <[email protected]>
Co-authored-by: haqadn <[email protected]>
Co-authored-by: haqadn <[email protected]>
…ages - Update logo and Dashboard button on modules/debugger pages to link to My Jetpack - Update settings page masthead logo to link to My Jetpack - Update About footer link to use jetpack-about redirect 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This reverts commit a03102c.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
3dfd914 to
7d3f7a1
Compare
|
I think the links make sense. The TOS link is consistent with what we show during the connection process. |
Related to MYJP-286
Proposed Changes
The Jetpack dashboard is being deprecated in favor of My Jetpack. This PR redirects user-facing links from
admin.php?page=jetpacktoadmin.php?page=my-jetpackand updates footer links to use external redirects consistently.About/Privacy/Automattic links: Now always use external redirects (
getRedirectUrl('jetpack-about'),getRedirectUrl('a8c-privacy')) instead of conditional internal/external logicOther information:
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No
Testing instructions: