Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 8, 2026

Related to MYJP-286

Proposed Changes

The Jetpack dashboard is being deprecated in favor of My Jetpack. This PR redirects user-facing links from admin.php?page=jetpack to admin.php?page=my-jetpack and updates footer links to use external redirects consistently.

About/Privacy/Automattic links: Now always use external redirects (getRedirectUrl('jetpack-about'), getRedirectUrl('a8c-privacy')) instead of conditional internal/external logic

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Browse Jetpack dashboard pages and ensure About, Privacy and Terms link point to the external links even after jetpack connection.
  • Visit debug(wp-admin/admin.php?page=jetpack-debugger), modules(wp-admin/admin.php?page=jetpack_modules) and other pages you can think of and make sure the logo and references to dashboard do not link to the old Jetpack dashboard, and instead point to My Jetpack.

Copilot AI changed the title [WIP] Update Jetpack dashboard links to My Jetpack Update Jetpack dashboard links to My Jetpack (MYJP-286) Jan 8, 2026
Copilot AI requested a review from haqadn January 8, 2026 21:59
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the copilot/update-dashboard-links-myjp-286 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack copilot/update-dashboard-links-myjp-286
bin/jetpack-downloader test jetpack-mu-wpcom-plugin copilot/update-dashboard-links-myjp-286

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [JS Package] Components [JS Package] Licensing [JS Package] Partner Coupon [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress [Tests] Includes Tests Admin Page React-powered dashboard under the Jetpack menu RNA labels Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: February 3, 2026
    • Code freeze: February 3, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 8, 2026
@jp-launch-control
Copy link

jp-launch-control bot commented Jan 8, 2026

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/js-packages/components/tools/get-site-admin-url/index.ts 0/1 (0.00%) -100.00% 1 ❤️‍🩹
projects/js-packages/components/components/jetpack-footer/index.tsx 16/16 (100.00%) 0.00% 0 💚
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php 0/190 (0.00%) 0.00% -3 💚

Full summary · PHP report · JS report

@github-actions github-actions bot added [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Inspect [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin labels Jan 12, 2026
@haqadn haqadn marked this pull request as ready for review January 12, 2026 23:54
Copilot AI review requested due to automatic review settings January 12, 2026 23:54
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f350636c5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<?php } ?>
</div>
<a class="jp-footer__a8c-logo" href="<?php echo esc_url( $jetpack_about_url ); ?>" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>">
<a class="jp-footer__a8c-logo" href="<?php echo esc_url( Redirect::get_url( 'a8c-about' ) ); ?>" target="_blank" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add noopener to new-tab external logo link

This link now opens in a new tab (target="_blank") but omits rel="noopener noreferrer", so the external redirect page can access window.opener and potentially navigate the original admin page (reverse tabnabbing). This only matters when the redirect resolves to an external origin, but that’s exactly the case here. Please add rel="noopener noreferrer" to match the other external links in this footer.

Useful? React with 👍 / 👎.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it's ok to skip it for automattic.com as it's trusted.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Jetpack dashboard links to redirect users to My Jetpack instead of the deprecated Jetpack dashboard. It simplifies the footer link logic by always using external redirects for About, Privacy, and Automattic links, removing the previous conditional behavior based on connection status.

Changes:

  • Updated primary dashboard links from admin.php?page=jetpack to admin.php?page=my-jetpack
  • Removed conditional logic for footer links, now consistently using external redirects
  • Deprecated the useInternalLinks prop in the JetpackFooter component while maintaining backwards compatibility

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
projects/plugins/jetpack/changelog/copilot-update-dashboard-links-myjp-286 Changelog entry documenting the bugfix for dashboard navigation links
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php Updated PHP footer and masthead to use My Jetpack links and external redirects consistently
projects/plugins/jetpack/_inc/client/components/masthead/index.jsx Modified React masthead logo to link to My Jetpack using siteAdminUrl
projects/js-packages/components/components/jetpack-footer/index.tsx Removed useInternalLinks logic, now always using external redirects for footer links
projects/js-packages/components/components/jetpack-footer/test/snapshots/component.tsx.snap Updated snapshot to reflect new rel and target attributes on Automattic logo link
projects/js-packages/components/changelog/update-dashboard-links-myjp-286 Changelog entry for the components package changes

<?php } ?>
</div>
<a class="jp-footer__a8c-logo" href="<?php echo esc_url( $jetpack_about_url ); ?>" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>">
<a class="jp-footer__a8c-logo" href="<?php echo esc_url( Redirect::get_url( 'a8c-about' ) ); ?>" target="_blank" aria-label="<?php echo esc_attr__( 'An Automattic Airline', 'jetpack' ); ?>">
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Automattic logo link is missing the rel="noreferrer" attribute. This attribute should be added for consistency with other external links in the footer and to prevent the Referer header from being sent to the external site. The TypeScript footer component includes this attribute (line 138 in jetpack-footer/index.tsx), and it should be consistent here as well.

Copilot uses AI. Check for mistakes.
@haqadn haqadn requested review from a team and manzoorwanijk January 13, 2026 00:01
@haqadn haqadn force-pushed the copilot/update-dashboard-links-myjp-286 branch from 3dfd914 to 7d3f7a1 Compare January 13, 2026 22:58
@haqadn haqadn added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jan 13, 2026
@grzegorz-cp
Copy link
Contributor

I think the links make sense. The TOS link is consistent with what we show during the connection process.

@haqadn haqadn merged commit 8d5bd1c into trunk Jan 15, 2026
93 of 94 checks passed
@haqadn haqadn deleted the copilot/update-dashboard-links-myjp-286 branch January 15, 2026 17:57
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 15, 2026
@github-actions github-actions bot added this to the jetpack/15.5 milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [JS Package] Components [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants