Skip to content

Add /LTCG:incremental option #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hwangsihu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add /LTCG:incremental option #3035

hwangsihu wants to merge 2 commits into from

Conversation

@hwangsihu
Copy link
Contributor

@hwangsihu hwangsihu commented Dec 6, 2025

No description provided.

@hwangsihu hwangsihu requested a review from bear101 as a code owner December 6, 2025 01:43
@hwangsihu hwangsihu requested a review from Copilot December 6, 2025 04:32
Copilot AI reviewed Dec 6, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

bear101
bear101 requested changes Dec 6, 2025
View reviewed changes
@hwangsihu hwangsihu force-pushed the ltcg branch 2 times, most recently from 449be62 to 9a021a1 Compare December 8, 2025 00:23
@bear101
Copy link
Contributor

bear101 commented Dec 10, 2025

What exactly is the benefit of this change? When I look at the size of TeamTalk5.dll on main branch and ltcg branch then it's exactly the same.

@hwangsihu
Copy link
Contributor Author

hwangsihu commented Dec 13, 2025

What exactly is the benefit of this change? When I look at the size of TeamTalk5.dll on main branch and ltcg branch then it's exactly the same.

Sorry, I just checked.
When compiling most files, you'll see a warning message saying that using the /ltcg option will improve linker performance.
This is in response to the warning.

@bear101
Copy link
Contributor

bear101 commented Dec 14, 2025

Looking at the build times I don't see any improvements in build time compared to master branch

@hwangsihu
Copy link
Contributor Author

hwangsihu commented Dec 14, 2025

But wouldn't it be nice if we could get rid of the warning message?

@bear101
Copy link
Contributor

bear101 commented Dec 17, 2025

By default VS2022 sets Link Time Code Generation to nothing (blank) for Debug and /LTCG:incremental for Release builds on DLL projects.

@hwangsihu
Copy link
Contributor Author

hwangsihu commented Jan 11, 2026 •
edited
Loading

@bear101 Ah, Did you mean to change /LTCG to /LTCG:incremental?

@hwangsihu hwangsihu changed the title Add /LTCG option Add /LTCG:incremental option Jan 11, 2026
@hwangsihu hwangsihu force-pushed the ltcg branch 2 times, most recently from 6701360 to ad4f698 Compare January 15, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear101 bear101 bear101 requested changes

Copilot code review Copilot Copilot left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hwangsihu @bear101