Revert "Do not patch CMake file in Tolk" #3090
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangsihu
force-pushed
the
revert-3019-tolk-rebuild
branch
from
4ecc7e0 to
bed19b0
Compare
Contributor
|
What is the idea with this PR? |
Contributor
Author
|
As the PR title suggests, this is a revert of the change. I think it's better to use the official tolk and patch only the necessary files. |
Contributor
|
But patching does not work with Rebuild in Visual Studio. |
Contributor
Author
|
So, I have a question. Is this only happening with tolk, or with everything that uses patch files? |
Contributor
|
When developing TOOLCHAIN_BUILD_EXTERNALPROJECTS is OFF. There no point in building the toolchain when you're developing features. It takes forever to build. |
Contributor
Author
|
@bear101, What if we do this? |
hwangsihu
force-pushed
the
revert-3019-tolk-rebuild
branch
from
278f25a to
50b9774
Compare
This reverts commit 26fccf1.
hwangsihu
force-pushed
the
revert-3019-tolk-rebuild
branch
from
50b9774 to
a012877
Compare
Contributor
|
If rebuild does not work in VS2022 then we cannot use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3019