pest to chumsky migration #185
Conversation
|
cc @canndrew may want to keep an eye on progress here |
gerau
force-pushed
the
simc/chumsky-migration
branch
from
6db55db to
1b1e751
Compare
|
Right now there is a working parser using the Error reporting is currently broken because we need to replace the logic of The code will be refactored because some parts are only half-finished (such as adding |
|
cc @canndrew |
| } | ||
|
|
||
| #[test] | ||
| #[ignore] |
There was a problem hiding this comment.
1b1e751 It's nice to see that chumsky seems to be faster than pest here.
gerau
force-pushed
the
simc/chumsky-migration
branch
from
1b1e751 to
1e7c61b
Compare
src/error.rs
Outdated
| }) | ||
| .map_or(0, |ts| u32::from(ts) as usize); | ||
|
|
||
| let start_col = file[line_start_byte..self.span.start].chars().count(); |
There was a problem hiding this comment.
Do we want to count columns as being the number of utf8 codepoints? There's no good way to define "number of columns" in general for non-ascii text, but LSP defines it as the number of utf16 codepoints and that's the closest thing to a standard that I'm aware of.
There was a problem hiding this comment.
Actually I just checked and LSP now allows you to choose between utf{8,16,32} at your leisure. But it's moot anyway since this is just deciding how long an underline to print and that's going to depend on the terminal.
There was a problem hiding this comment.
We should consider switching to ariadne for error pretty-printing, as it's the "sister-crate" for chumsky.
|
It's weird that the lexer is treating all our built-in macro/function/etc names as being keywords. I realize that's how the compiler currently works, so it's okay to land this PR as-is to keep the changes small. But obviously we'd want to eventually treat these as just being identifiers. |
gerau
force-pushed
the
simc/chumsky-migration
branch
from
3592b31 to
c03241c
Compare
This commit introduce multiple changes, because it full rewrite of parsing and error Changes in `error.rs`: - Change `Span` to use byte offsets in place of old `Position` - Add `line-index` crate to calculate line and column of byte offset - Change `RichError` implementation to use new `Span` structure - Implement `chumsky` error traits, so it can be used in error reporting of parsers - add `expected..found` error Changes in `parse.rs`: - Fully rewrite `pest` parsers to `chumsky` parsers. - Change `ParseFromStr` trait to use this change.
This adds `ParseFromStrWithErrors`, which would take `ErrorCollector` and return an `Option` of AST. Also changes `TemplateProgram` to use new trait with collector
it's not slow anymore
gerau
force-pushed
the
simc/chumsky-migration
branch
from
c03241c to
bd5c30f
Compare
4 participants
No description provided.