Skip to content

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 16, 2026

Summary of changes

Changes introduced in this pull request:

  • fixes => => # Installing Forest binaries with profile: release => => # sh: 2: [[: not found when installing Forest.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Updated task execution configuration to properly support Bash-specific syntax and features in installation operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 16, 2026 12:27
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team January 16, 2026 12:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Walkthrough

A single configuration property was added to the [tasks.install] section in mise.toml. The shell = "bash -c" directive specifies Bash as the shell execution context for the install task's run script.

Changes

Cohort / File(s) Summary
Configuration
mise.toml
Added shell = "bash -c" to [tasks.install] section to specify Bash shell execution for the install task

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • hanabi1224
  • sudo-shashank
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: wrong shell for mise task' directly relates to the main change, which adds shell = "bash -c" to fix a shell execution error in the mise task.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@mise.toml`:
- Line 10: The shell property uses bash correctly but is formatted without
spaces; update the TOML property name/value formatting by changing shell="bash
-c" to shell = "bash -c" so it matches the file's style (e.g., similar to
description and run properties) and satisfies taplo fmt/lint checks.
📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a51d976 and 9d58704.

📒 Files selected for processing (1)
  • mise.toml
🧰 Additional context used
📓 Path-based instructions (1)
**/*.toml

📄 CodeRabbit inference engine (AGENTS.md)

Ensure TOML files are formatted correctly using taplo fmt and pass taplo lint

Files:

  • mise.toml
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: ChainSafe/forest PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-14T10:25:49.996Z
Learning: Ensure all tests pass with `mise test` before submitting pull requests
Learnt from: LesnyRumcajs
Repo: ChainSafe/forest PR: 5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: tests-release
  • GitHub Check: rubocop
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Coverage
  • GitHub Check: All lint checks

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 058b4b2 Jan 16, 2026
40 of 41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-mise-install-task branch January 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants