Skip to content

Conversation

@not-matthias
Copy link
Member

@not-matthias not-matthias commented Jan 15, 2026

Works as expected now:

$ cargo bench
   Compiling codspeed v4.2.1 (/home/not-matthias/Documents/work/wgit/codspeed-rust/crates/codspeed)
   Compiling codspeed-divan-compat-walltime v4.2.1 (/home/not-matthias/Documents/work/wgit/codspeed-rust/crates/divan_compat/divan_fork)
   Compiling codspeed-divan-compat v4.2.1 (/home/not-matthias/Documents/work/wgit/codspeed-rust/crates/divan_compat)
    Finished `bench` profile [optimized] target(s) in 3.69s
     Running unittests src/lib.rs (/home/not-matthias/Documents/work/wgit/codspeed-rust/target/release/deps/codspeed_divan_compat-80cd5bd1ab1d286e)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/basic_example.rs (/home/not-matthias/Documents/work/wgit/codspeed-rust/target/release/deps/basic_example-a9e1bda108a3123a)
Timer precision: 20 ns
basic_example       fastest       │ slowest       │ median        │ mean          │ samples │ iters
├─ fibo_10          1.223 ns      │ 8.845 ns      │ 1.229 ns      │ 1.321 ns      │ 100     │ 204800
├─ fibo_50          1.526 ns      │ 3.582 ns      │ 1.532 ns      │ 1.557 ns      │ 100     │ 204800
├─ mut_borrow       1.116 ns      │ 23.41 ns      │ 1.794 ns      │ 2.324 ns      │ 100     │ 204800
╰─ const_bench                    │               │               │               │         │
   ├─ bench_array1                │               │               │               │         │
   │  ├─ 1          1.223 ns      │ 1.234 ns      │ 1.229 ns      │ 1.227 ns      │ 100     │ 204800
   │  ├─ 4          7.421 ns      │ 31.86 ns      │ 7.46 ns       │ 7.722 ns      │ 100     │ 51200
   │  ├─ 10         9.552 ns      │ 11.66 ns      │ 9.595 ns      │ 9.68 ns       │ 100     │ 25600

Depends on CodSpeedHQ/instrument-hooks#18

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the instrument-hooks submodule dependency to incorporate fixes that enable proper benchmark execution with the codspeed-divan-compat crate.

Changes:

  • Updated instrument-hooks submodule commit reference to version 8e6c3d2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 3.49%

Comparing cod-2025-bump-instrument-hooks-in-rust-to-allow-running-benchmarks (d6cfa72) with main (693edb3)

Summary

❌ 1 regressed benchmark
✅ 390 untouched benchmarks
⏩ 189 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation process_items_with_counter 806.7 ns 835.8 ns -3.49%

Footnotes

  1. 189 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants