feat(memtrack): add C++ and Rust integration tests #212
+2,035
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
force-pushed
the
cod-2002-add-rust-c-integration-tests-to-runner
branch
from
9477d9a to
b3231ff
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
not-matthias
force-pushed
the
cod-2002-add-rust-c-integration-tests-to-runner
branch
4 times, most recently
from
63327c6 to
cea4068
Compare
not-matthias
force-pushed
the
cod-2002-add-rust-c-integration-tests-to-runner
branch
from
cea4068 to
614ab90
Compare
not-matthias
force-pushed
the
cod-2002-add-rust-c-integration-tests-to-runner
branch
from
614ab90 to
2670fb3
Compare
not-matthias
force-pushed
the
cod-2002-add-rust-c-integration-tests-to-runner
branch
from
2670fb3 to
51536d2
Compare
GuillaumeLagrange
approved these changes
Jan 29, 2026
|
|
||
| type TrackResult = anyhow::Result<(Vec<Event>, std::thread::JoinHandle<()>)>; | ||
|
|
||
| macro_rules! assert_events_with_marker { |
Contributor
There was a problem hiding this comment.
Can we add an example usage as docstring here
| @@ -1,38 +1,13 @@ | |||
| use libbpf_rs::ErrorExt; | |||
| use memtrack::{EventType, MemtrackEventExt, Tracker}; | |||
| mod shared; | |||
Contributor
There was a problem hiding this comment.
couldnt we get rid of all the checking logic and add snapshots here as well ?
|
|
||
| // Prefixed standard API | ||
| // je_*_default API (C++ with static linking) | ||
| self.try_attach_malloc(lib_path, "je_malloc_default"); |
Contributor
There was a problem hiding this comment.
I can see this becoming quite an annoying thing to maintain over time.
Could we have some sort of structured consts for each allocator that would just be
struct AllocatorSymbols {
pub malloc_symbols = [...];
pub ...
}then each prob attach function would just loop over each symbol and call the proper functoin
Feel free to disregard if you dont see the point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posix_memalignandlibstdc++(libc but for C++)