Skip to content

fix a bug in the ACE log mechanism when using a '%#T' format string t… #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esohns wants to merge 4 commits into
base: master
Choose a base branch
from
+98 −3
Open

fix a bug in the ACE log mechanism when using a '%#T' format string t… #2484

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
612663c
fix a bug in the ACE log mechanism when using a '%#T' format string t…
esohns Nov 22, 2025
78bcf26
incorporated AI review comments
esohns Nov 22, 2025
3bbf8f3
minor update
esohns Nov 22, 2025
1fdf1ba
print message to stderr instead of asserting
esohns Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ACE/ace/ACE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2415,7 +2415,10 @@ ACE::timestamp (const ACE_Time_Value& time_value,
ACE_Time_Value (ACE_OS::gettimeofday ()) : time_value;
time_t secs = cur_time.sec ();
struct tm tms;
ACE_OS::localtime_r (&secs, &tms);
if (time_value == ACE_Time_Value::zero)
ACE_OS::localtime_r (&secs, &tms);
else
ACE_OS::gmtime_r (&secs, &tms);
ACE_OS::snprintf (date_and_time,
date_and_timelen,
ACE_TEXT ("%4.4d-%2.2d-%2.2d %2.2d:%2.2d:%2.2d.%06ld"),
Expand Down
Loading