Add waterdata demo #208
Add waterdata demo #208
Conversation
jzemmels
left a comment
jzemmels
left a comment
There was a problem hiding this comment.
This is great! I appreciate the consistent throughline example. I've just a few comments that you might consider, but I'm only requesting changes on the errors I ran into (the double monitoring_location_id error + the GeoPandas-dependent code).
| "metadata": {}, | ||
| "source": [ | ||
| "## Lay of the Land\n", | ||
| "Now that your API key is configured, it's time to take a 10,000-ft view of the functions in the `waterdata` module.\n", |
There was a problem hiding this comment.
Might be good to link to the specific OGC API homepage somewhere -- maybe here? https://api.waterdata.usgs.gov/ogcapi
There was a problem hiding this comment.
Will add to resources section.
| ] | ||
| } | ||
| ], | ||
| "metadata": { |
There was a problem hiding this comment.
End the vignette with a list of links/resources to learn more
Co-authored-by: Joe Zemmels (he/him) <[email protected]>
|
@jzemmels I think this is ready for a second look. I have fixed the duplicated ID column issue in the The one little hitch I've run into is that there was some discussion in the |
Co-authored-by: Joe Zemmels (he/him) <[email protected]>
| "* [Water Data for the Nation Home](https://waterdata.usgs.gov/)\n", | ||
| "* [Water Data for the Nation Feedback Form](https://waterdata.usgs.gov/questions-comments/?referrerUrl=https://api.waterdata.usgs.gov)\n", | ||
| "* [R dataRetrieval package](https://github.com/DOI-USGS/dataretrieval)\n", | ||
| "* [WDFN Blog Post on NWISWeb Decommissioning Timeline](https://waterdata.usgs.gov/blog/nwisweb-decommission-campaign2/)\n" |
There was a problem hiding this comment.
@jzemmels Are there any that you would add?
Thanks so much for the help! |
2 participants
Built off the PR that adds reference table functions.
Adds a demo of the
waterdatafunctions todrpy. Addresses: #200Also adds a few query parameters to the
get_time_series_metadata()function.