Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 16, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

How did you test this code?

E2E, checking each usage of permission

Note: due to amount of refactoring I've done, I've pointed this to the latest branch I've been working on

…on-types

# Conflicts:
#	frontend/common/providers/Permission.tsx
#	frontend/web/components/modals/create-feature/index.js
…on-types

# Conflicts:
#	frontend/web/components/modals/create-feature/index.js
@kyle-ssg kyle-ssg requested a review from a team as a code owner December 16, 2025 15:42
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team December 16, 2025 15:42
@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 13, 2026 4:20pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 13, 2026 4:20pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 13, 2026 4:20pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6417 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6417 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6417 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6417 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6417 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6417 Finished ✅ Results

@kyle-ssg kyle-ssg changed the title Chore/permission types chore: permission types Dec 16, 2025
@kyle-ssg kyle-ssg requested a review from Zaimwa9 December 16, 2025 15:52
@github-actions github-actions bot added the chore label Dec 16, 2025
@Zaimwa9 Zaimwa9 removed their request for review December 31, 2025 14:36
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat. There are just 2 conditions that got truncated somehow and a couple of NITs

@kyle-ssg
Copy link
Member Author

Ok! all refactored and no typescript errors exist that relate to permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission check for editing an identities feature needs "UPDATE_FEATURE_STATE" permission

3 participants