-
Notifications
You must be signed in to change notification settings - Fork 467
chore: permission types #6417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kyle-ssg
wants to merge
17
commits into
feat/edit-versioned-change-request
Choose a base branch
from
chore/permission-types
base: feat/edit-versioned-change-request
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: permission types #6417
kyle-ssg
wants to merge
17
commits into
feat/edit-versioned-change-request
from
chore/permission-types
+544
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-types # Conflicts: # frontend/common/providers/Permission.tsx # frontend/web/components/modals/create-feature/index.js
…on-types # Conflicts: # frontend/web/components/modals/create-feature/index.js
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Docker builds report
|
Open
4 tasks
Zaimwa9
requested changes
Jan 5, 2026
Contributor
Zaimwa9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat. There are just 2 conditions that got truncated somehow and a couple of NITs
Co-authored-by: Zaimwa9 <[email protected]>
Co-authored-by: Zaimwa9 <[email protected]>
Co-authored-by: Zaimwa9 <[email protected]>
3f6e1b8 to
58b4245
Compare
Member
Author
|
Ok! all refactored and no typescript errors exist that relate to permissions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
How did you test this code?
E2E, checking each usage of permission
Note: due to amount of refactoring I've done, I've pointed this to the latest branch I've been working on