Skip to content

refactor: restore FeaturesPage RTK Query migration with MV and CR fixes #6469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
talissoncosta wants to merge 11 commits into
base: main
Choose a base branch
from
Open

refactor: restore FeaturesPage RTK Query migration with MV and CR fixes #6469

talissoncosta wants to merge 11 commits into from
+1,961 −663

Conversation

@talissoncosta
Copy link
Contributor

@talissoncosta talissoncosta commented Jan 5, 2026 •
edited
Loading

Summary

Restores the FeaturesPage RTK Query migration

Changes

  • Sync Flux store with RTK Query pagination/filter state
  • Add E2E tests for multivariate toggle and change request workflows
  • Add refetchOnFocus for features list (equivalent to feat: re-fetch features on page focus #6483)
  • Fix view mode toggle delay (was 5-10s, now instant) with optimistic UI updates
  • Fix Groups filter not loading (was using undefined routeContext.organisationId)

Test Plan

Automated (E2E)

  • All existing flag-tests pass

Manual Testing

QA List

Related Issues

@talissoncosta talissoncosta requested a review from a team as a code owner January 5, 2026 23:59
@talissoncosta talissoncosta requested review from kyle-ssg and removed request for a team January 5, 2026 23:59
@vercel
Copy link

vercel bot commented Jan 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jan 14, 2026 11:01am
flagsmith-frontend-staging Ready Ready Preview, Comment Jan 14, 2026 11:01am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 14, 2026 11:01am

@talissoncosta talissoncosta marked this pull request as draft January 5, 2026 23:59
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6469 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6469 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6469 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-6469 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6469 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-6469 Finished ✅ Results ✅

@github-actions github-actions bot added the api Issue related to the REST API label Jan 6, 2026
@talissoncosta talissoncosta changed the title Revert "fix: revert: "fix(features): restore FeaturesPage RTK Query migration with versioning fixes"" [WIP]: Revert "fix: revert: "fix(features): restore FeaturesPage RTK Query migration with versioning fixes"" Jan 6, 2026
@talissoncosta talissoncosta marked this pull request as ready for review January 6, 2026 13:43
@talissoncosta talissoncosta requested a review from a team as a code owner January 6, 2026 13:43
@talissoncosta talissoncosta requested review from emyller and removed request for a team January 6, 2026 13:43
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (38ac162) to head (0926c8f).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6469   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files        1294     1294           
  Lines       46535    46537    +2     
=======================================
+ Hits        45637    45639    +2     
  Misses        898      898

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from 0926c8f to f7540cc Compare January 6, 2026 15:31
@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from f7540cc to 459f824 Compare January 6, 2026 15:35
@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from 4270d2a to 459f824 Compare January 6, 2026 16:13
@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from f57bbe0 to ed0388b Compare January 6, 2026 18:28
cursor[bot]
cursor bot reviewed Jan 13, 2026
View reviewed changes
@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from a88c82d to e62b0b8 Compare January 13, 2026 12:40
cursor[bot]
cursor bot reviewed Jan 13, 2026
View reviewed changes
cursor[bot]
cursor bot reviewed Jan 13, 2026
View reviewed changes
@talissoncosta talissoncosta force-pushed the revert-6468-revert-6429-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2 branch from a5984e5 to fa112b5 Compare January 13, 2026 13:32
@talissoncosta @claude
fix(store): add setupListeners to enable RTK Query refetchOnFocus
f383648 
The service.ts had refetchOnFocus: true configured, but without calling
setupListeners() from RTK Query, the window focus event listener was
never set up. This restores the refetch-on-focus behaviour that existed
in the old FeaturesPage.js implementation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@Zaimwa9
Copy link
Contributor

Zaimwa9 commented Jan 13, 2026 •
edited
Loading

QA Plan ENV V1 bis

List view (compact and normal views)

  • Enable/Disable flag from list
  • Open modal
  • I can search a flag
  • I can filter/unfilter with a tag
  • I can filter/unfilter with a value 🟠 => discussed following PR
  • I can filter/unfilter with a users
  • I can filter/unfilter groups
  • I can sort my flags by name or created_at

In modal

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline
  • I can remove a feature from a release pipeline (if applicable)
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments
  • I am redirected to user page if I want to edit an identity
  • I can delete an identity
  • I can add/remove a tag to my flag
  • I can update a custom field on my feature
  • I can assign/remove users
  • I can assign/remove groups
  • I can add a description
  • I can enable/disabled server side
  • I can archive/unarchive my flag

@Zaimwa9
Copy link
Contributor

Zaimwa9 commented Jan 13, 2026

QA Plan ENV V1 With change requests

List view (compact and normal views)

  • Open modal
  • I can search a flag
  • I can filter/unfilter with a tag
  • I can filter/unfilter with a value 🟠 => discussed following PR
  • I can filter/unfilter with a users
  • I can filter/unfilter groups
  • I can sort my flags by name or created_at

In modal

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline
  • I can remove a feature from a release pipeline (if applicable)
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments
  • I am redirected to user page if I want to edit an identity
  • I can delete an identity
  • I can add/remove a tag to my flag
  • I can update a custom field on my feature
  • I can assign/remove users
  • I can assign/remove groups
  • I can add a description
  • I can enable/disabled server side
  • I can archive/unarchive my flag

@talissoncosta talissoncosta mentioned this pull request Jan 13, 2026
Open
@talissoncosta
Copy link
Contributor Author

talissoncosta commented Jan 13, 2026

Known Issue - Value Filter Clear

There's a known issue where the "Clear all" filters button doesn't properly clear the Value filter due to race conditions with debounced state.

Issue: #6523

This will be addressed in a follow-up PR as it requires changes to the shared useDebouncedSearch hook and proper callback memoization across multiple components.

@talissoncosta
Copy link
Contributor Author

talissoncosta commented Jan 13, 2026 •
edited
Loading

QA Plan ENV V2 With change requests

List view (compact and normal views)

  • Open modal
  • I can search a flag
  • I can filter/unfilter with a tag
  • I can filter/unfilter with a value 🟠 => Issue created to handle that
  • I can filter/unfilter with a users
  • I can filter/unfilter groups
  • I can sort my flags by name or created_at

In modal

  • I can enable/disable my flag
  • I can update the value of my flag
  • I can update the value of a MV option
  • I can update the weight of a MV option
  • I can create a MV option
  • I can delete a MV option
  • I can add a feature to a release pipeline
  • I can remove a feature from a release pipeline (if applicable)
  • I can create a Feature specific segment
  • I can attach a Feature specific segment
  • I can attach an existing segment
  • I can disable all segment
  • I can save my segments
  • I am redirected to user page if I want to edit an identity
  • I can delete an identity
  • I can add/remove a tag to my flag
  • I can update a custom field on my feature
  • I can assign/remove users
  • I can assign/remove groups
  • I can add a description
  • I can enable/disabled server side
  • I can archive/unarchive my flag

@talissoncosta
Merge remote-tracking branch 'origin/main' into revert-6468-revert-64…
f022518 
…29-revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Zaimwa9 Zaimwa9 Zaimwa9 requested changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

api Issue related to the REST API front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@talissoncosta @Zaimwa9