[ENHANCEMENT] Clean up duplicate constants and implement new audio constants. #6747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
Hundrec
added
type: enhancement
Starexify
force-pushed
the
constants-extra
branch
from
674f90c to
15130c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the game's codebase by adding audio paths as constants, using already existing constants as values and removing duplicate constants that are found in different classes and contain the same values.
Modding
Modders can now easily change core engine sounds (like the screenshot, volume sounds or chart editor sounds) by modifying these values. This removes the need to hunt through different states or sound pools to stop or replace the sound.