bigquery: add policyTags support to ignore_schema_changes on google_b… #16248
+609
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igquery_table Add support for 'policyTags' as a value in the ignore_schema_changes virtual field on google_bigquery_table. This mirrors the existing 'dataPolicies' implementation and allows users to ignore externally- applied policy tag changes (e.g., from automated PII tagging tools) without having to ignore the entire schema. When ignore_schema_changes includes 'policyTags': - Policy tags set outside Terraform are preserved during updates - Policy tags explicitly set in the Terraform config override live state - Diff suppression prevents plan noise from external tag changes - Recursive handling supports nested RECORD/STRUCT types Includes unit tests (diff suppress, merge struct, merge map, isChangeable) and acceptance test (3-stage create/add/merge verification). :house: Remote-Dev: homespace
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
policyTagsas a value in theignore_schema_changesvirtual field ongoogle_bigquery_table. This mirrors the existingdataPoliciesimplementation (PR #23495, PR #25721) and allows users to ignore externally-applied policy tag changes without having to ignore the entire schema.Problem
BigQuery policy tags (
policyTags) are often managed outside Terraform by automated tools (e.g., PII auto-taggers that scan tables daily). Since theschemaattribute is a single JSON blob,ignore_changescannot target individual fields within it — users must either ignore the entire schema or manually track every tag change in their Terraform config.The
ignore_schema_changesfield already supportsdataPolicies(data masking policies). This PR extends it to also supportpolicyTags(column-level access control tags), which are a different schema field (TableFieldSchema.policyTagsvsTableFieldSchema.dataPolicies).Related Issues
Behavior
When
ignore_schema_changes = ["policyTags"]is set:Changes
resource_bigquery_table.go.tmpl: AddedmergePolicyTags()andmergePolicyTagsIntoMap()functions, updated diff suppression, CustomizeDiff, and Update logicresource_bigquery_table_internal_test.go.tmpl: Unit tests for diff suppress, merge struct, merge map, isChangeableresource_bigquery_table_test.go: 3-stage acceptance test (TestAccBigQueryTable_PolicyTagsMerge)bigquery_table.html.markdown: Updated docs to mentionpolicyTagsalongsidedataPolicies