Skip to content

Conversation

@Fryy55
Copy link

@Fryy55 Fryy55 commented Aug 5, 2025

This PR consists of 2 main changes:

  1. I’ve changed the way “Next Free” buttons are handled in mixed value inputs. Now they store a pointer to SetGroupIDLayer’s member callback function, and create the button if a callback is present. This helps maintain compatibility with other mods, as well as reduces boilerplate. Another change to this system is the “Next Free” button’s offset - for trigger order this button should be located to the left of the input field, which is handled with the offset. The “Next Free ORD” button not appearing is also fixed with these changes.
  2. MixedValuesConfig now has the placeholder text field, which, if present, replaces the default “Num” placeholder text of the input field and makes going to 0 on the input field show the placeholder. This is necessary for CH and ORD input fields and is a vanilla feature, because those input fields lack description labels and are hard to tell apart without them.

Hope you find these changes useful and worth merging.

Best regards,
Fryy_55 💜

@Fryy55 Fryy55 marked this pull request as draft August 5, 2025 06:54
@Fryy55 Fryy55 marked this pull request as ready for review August 5, 2025 06:58
@Fryy55
Copy link
Author

Fryy55 commented Aug 5, 2025

ok idk how to add issues to the sidebar but it fixes #644

Copy link
Owner

@HJfod HJfod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues that make this unable to be merged yet, but overall looks good! Thank you very much!

@Fryy55 Fryy55 requested a review from HJfod August 14, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants