Skip to content

Xray initial support #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artemnikitin wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Xray initial support #273

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
276782e
Initial support of X-Ray tracing
artemnikitin Jun 24, 2018
27e1d98
Initial support of X-Ray tracing
artemnikitin Jun 24, 2018
852d35b
Merge branch 'xray-initial-support' of https://github.com/artemnikiti…
artemnikitin Jun 24, 2018
1ea38d8
Fix panic on missing context
artemnikitin Jul 1, 2018
4367ddd
Merge branch 'master' into xray-initial-support
artemnikitin Jul 6, 2018
ed2fa69
Fixing passing wrong context
artemnikitin Jul 10, 2018
245d7f7
Configure X-Ray SDK log level via flag
artemnikitin Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion autospotting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (

"github.com/aws/aws-lambda-go/lambda"
"github.com/aws/aws-sdk-go/aws/endpoints"
"github.com/aws/aws-xray-sdk-go/strategy/ctxmissing"
"github.com/aws/aws-xray-sdk-go/xray"
"github.com/cristim/autospotting/core"
"github.com/cristim/ec2-instances-info"
Expand Down Expand Up @@ -58,7 +59,10 @@ func run(ctx context.Context) {
conf.TagFilteringMode,
conf.SpotProductDescription)

xray.Configure(xray.Config{LogLevel: "error"})
xray.Configure(xray.Config{
ContextMissingStrategy: ctxmissing.NewDefaultLogErrorStrategy(),
Copy link
Member

@cristim cristim Jul 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much better than I had attempted... I'm just sorry I wasted a few hours trying to fix this myself without any results.

I'll try it out tomorrow.

Copy link
Member

@cristim cristim Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm!

LogLevel: "error",
})
Copy link
Contributor

@xlr-8 xlr-8 Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be configurable from an env variable?

Copy link
Contributor Author

@artemnikitin artemnikitin Jul 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly do you want to configure in this place? Log level?

Copy link
Contributor Author

@artemnikitin artemnikitin Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made log level configurable via flag, but it looks like there is a bug in X-Ray SDK. aws/aws-xray-sdk-go#60. At the moment, it will post a particular error message ignoring log level...

autospotting.Run(ctx, conf.Config)
log.Println("Execution completed, nothing left to do")
}
Expand Down