Add land and sea mask recipes for timeseries #1874
Open
+241
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
When reviewing be aware of #1876. |
Contributor
Author
|
Need to check how NaNs are handled in collapse as might be causing a problem or two in runs coming up with no values. |
daflack
force-pushed
the
1873_land_sea_mask_application
branch
3 times, most recently
from
5d9a7bb to
75ed7e0
Compare
daflack
force-pushed
the
1873_land_sea_mask_application
branch
from
75ed7e0 to
b04e6eb
Compare
and adds extra test
Contributor
Author
|
Fix in commit e6dadd0 linked to #984 and may help close that issue (not sure if it fully closes it). |
Contributor
Author
Evidence of the land-sea mask splits working as expected for four difference models.
|
daflack
requested review from
BernardClaxton,
Sylviabohnenstengel,
cehalliwell,
jfrost-mo,
mo-jthornton,
mo-sanamahmood and
mo-sro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1873
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.