Refactor cccl diagnostics #7137
Draft
+482
−623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
force-pushed
the
fix_diag_in_device_fns
branch
from
740358c to
53dbdbc
Compare
davebayer
force-pushed
the
fix_diag_in_device_fns
branch
from
43b4c9c to
2d18d19
Compare
Contributor
😬 CI Workflow Results🟥 Finished in 7h 19m: Pass: 38%/200 | Total: 18d 23h | Max: 6h 00m | Hits: 32%/133779See results here. |
miscco
reviewed
Jan 9, 2026
| // code .. | ||
| _CCCL_DIAG_POP | ||
|
|
||
| _CCCL_DIAG_PUSH_AND_SUPPRESS(NV, 171) // should be used only for suppressions for 1 compiler |
Contributor
There was a problem hiding this comment.
I would add an explicit example of 2 different compiler warnings getting suppressed
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the cccl diagnostics module, removing the old
_CCCL_DIAG_SUPPRESS_MEOW("-Wwarning1")macros with_CCCL_DIAG_SUPPRESS(MEOW, "-Wwarning1", "-Wwarning2").I've also unified host & nv diagnostics suppression, so it's enough to type
_CCCL_DIAG_POPnow. Look at the docs and<cuda/std/__cccl/diagnostic.h>to understand what's happening :)