Fix slow test_patterngen_seeds on Windows by sampling #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy-Jost
added
bug
Contributor
Contributor
Author
|
/ok to test c48274e |
Andy-Jost
commented
Jan 12, 2026
| log("done") | ||
|
|
||
|
|
||
| @pytest.mark.skipif( |
Contributor
Author
There was a problem hiding this comment.
I could leave this in if we want to continue skipping this test on Windows. It is not important to test this on every platform IMO.
Contributor
Author
|
The test runs in 0.19s on Linux. |
|
rwgk
reviewed
Jan 12, 2026
| log("done") | ||
|
|
||
|
|
||
| @pytest.mark.skipif( |
cuda_core/tests/test_helpers.py
Outdated
| # especially on Windows. See https://github.com/NVIDIA/cuda-python/issues/1455 | ||
| pgen = PatternGen(device, NBYTES) | ||
| for i in range(256): | ||
| for i in range(0, 256, 17): |
Collaborator
There was a problem hiding this comment.
This isn't covering the usual trouble-maker corner case 1 anymore.
This would sample around the usual suspects (0, 1 corner case, then a couple around powers of 2):
(0, 1, 2, 3, 4, 5, 31, 32, 33, 127, 128, 129)
Contributor
Author
There was a problem hiding this comment.
OK, I included values <5 since those are the most common. I don't think there's anything special about powers of two in this case.
Replace exhaustive O(n²) pairwise seed testing with prime-stride sampling, reducing iterations from ~32k to ~100 while maintaining meaningful coverage. Closes NVIDIA#1455
Andy-Jost
force-pushed
the
fix-slow-patterngen-test
branch
from
c48274e to
d39f754
Compare
Contributor
Author
|
/ok to test d39f754 |
rwgk
approved these changes
Jan 12, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
That looks nice!
>>> n = 0
>>> for i in (ii for ii in range(0, 256) if ii < 5 or ii % 17 == 0):
... js = tuple(jj for jj in range(i + 1, 256) if jj < 5 or jj % 19 == 0)
... print(i, js)
... n += len(js)
...
0 (1, 2, 3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
1 (2, 3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
2 (3, 4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
3 (4, 19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
4 (19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
17 (19, 38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
34 (38, 57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
51 (57, 76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
68 (76, 95, 114, 133, 152, 171, 190, 209, 228, 247)
85 (95, 114, 133, 152, 171, 190, 209, 228, 247)
102 (114, 133, 152, 171, 190, 209, 228, 247)
119 (133, 152, 171, 190, 209, 228, 247)
136 (152, 171, 190, 209, 228, 247)
153 (171, 190, 209, 228, 247)
170 (171, 190, 209, 228, 247)
187 (190, 209, 228, 247)
204 (209, 228, 247)
221 (228, 247)
238 (247,)
255 ()
>>> print(n)
171
Contributor
Author
|
/ok to test a4dcee1 |
Contributor
Author
|
/ok to test d0454f2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
skipifIS_WINDOWSfortest_patterngen_seeds#1456, re-enabling the test on WindowsCloses #1455