cuda.core.system: More device-related APIs #1465
Open
+881
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds device-related APIs to cuda.core.system, focusing on InfoROM inspection and detailed PCI topology information.
Changes:
- Added new InfoROM inspection APIs including version retrieval, configuration checksum, and validation
- Extended PCI information with subsystem ID, class codes, link generation/width details, throughput, and replay counter
- Added device topology and P2P status query capabilities with support for CPU affinity-based device enumeration
- Introduced new device properties: index, module_id, minor_number, board_part_number, addressing_mode, display_mode/active, and repair_status
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| cuda_core/tests/system/test_system_device.py | Added comprehensive tests for new device APIs including PCI info extensions, InfoROM operations, topology queries, and device properties |
| cuda_core/docs/source/api.rst | Updated API documentation to include new classes and functions for device topology, P2P status, InfoROM, and PCI utilities |
| cuda_core/cuda/core/system/_inforom.pxi | New file implementing InforomInfo class with methods for version retrieval, validation, and BBX flush time tracking |
| cuda_core/cuda/core/system/_device.pyx | Extended PciInfo with new properties and methods, added Device properties and topology methods, new module-level topology/P2P functions, and RepairStatus class |
| cuda_bindings/cuda/bindings/_nvml.pyx | Refactored system event APIs to be more Pythonic, fixed device_get_last_bbx_flush_time to return tuple, added SystemEventData_v1 class, and corrected accounting_stats_dtype reserved field |
| cuda_bindings/cuda/bindings/_nvml.pxd | Updated function signatures to match refactored implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
/ok to test |
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
/ok to test |
mdboom
added
feature
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sort of a grab bag of more APIs for
cuda.core.system, mainly related to InfoROM inspection and more detailed information about PCI topology.Checklist