Update gql.resolver to unlock the ability to attach more error information #2259
+435
−326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps taken: - delete dependencies.lock file in every module - update graphql-dgs-platform to strictly enforce snapshot version - ensure the graphql-java version from graphql-dgs-platform takes precedence over the Spring Boot one as it also manages graphql-java - re-gen the dependencies.lock files
to grab the ChainedInstrumentation change
tinnou
commented
Jan 16, 2026
| import graphql.execution.instrumentation.parameters.InstrumentationFieldFetchParameters | ||
| import io.micrometer.core.instrument.Tag | ||
|
|
||
| @Deprecated("Use DgsFieldFetchDataFetcherResultTagCustomizer instead") |
Collaborator
Author
There was a problem hiding this comment.
Should we rather deprecate or remove and bump the framework version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
This PR unlocks providing richer information for the
gql.resolvermetric using thebeginFieldFetchinginstead ofinstrumentDataFetcherinstrumentation hook. In graphql-java 26.x, a new callbackonExceptionHandledwas added, which allows observing the data fetcher result after exception handling has occurred. This allows the DGS framework to collect final error information on the data fetcher result and to compute latency on a single metric.An additional interface
DgsFieldFetchDataFetcherResultTagCustomizerhas been introduced to ultimately replaceDgsFieldFetchTagCustomizerwhich is now deprecated but still present for backward compatibility.Note: Both of these functional interfaces are called but
DgsFieldFetchDataFetcherResultTagCustomizertakes precedence if the same tag keys happened to be collected.