Re-enable support for deterministic pack #7020
Draft
+126
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building nuspec-based packages, the deterministic-mode configuration is not flowed correctly to the PackageBuilder class (which is initialized using this PackArgs object). Seems like this was missed from the initial deterministic support in NuGet#2989. This commit is a no-op until deterministic mode is enabled and NuGet/Home#8601 is fixed.
dotnet-policy-service
bot
added
the
Community
omajid
force-pushed
the
deterministic-pack-nuspec-file
branch
4 times, most recently
from
19b6b2f to
aa6ce30
Compare
Deterministic support was disabled due to various concerns some time ago: NuGet/Home#8601 This PR re-enables deterministic support, while adding support for SOURCE_DATE_EPOCH to override it. SOURCE_DATE_EPOCH is specified at: https://reproducible-builds.org/docs/source-date-epoch/
Add support for a new MSBuild property that developrs can use to override the deterministic timestamp. This allows developers to override the auto-computed timetsamps, and enables working around processes/tools that don't like the fixed/old timetsamps.
omajid
force-pushed
the
deterministic-pack-nuspec-file
branch
from
aa6ce30 to
50b60af
Compare
dotnet-policy-service
bot
added
the
Status:No recent activity
Contributor
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 30 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8601
Description
PR Checklist