Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 13171675 #7044
Conversation
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
…: Build ID 13082823
| <trans-unit id="BindingRedirectsHeader.Text"> | ||
| <source>Binding Redirects</source> | ||
| <target state="translated">Przekierowania wiązań</target> | ||
| <target state="translated">Przekierowania powiązań</target> |
There was a problem hiding this comment.
@martinrrm any idea why existing translations are changing?
There was a problem hiding this comment.
One of the steps in the branching template is to notify the loc team to change which servicing branch they monitor.
Looking at the release/7.0.x branch, I see the translation that this PR wants to use: https://github.com/NuGet/NuGet.Client/blob/release/7.0.x/src/NuGet.Clients/NuGet.PackageManagement.UI/Options/xlf/GeneralOptionControl.pl.xlf#L7
So, it looks to me like the OneLoc system is trying to use the 7.0.x translations on all branches, probably because they use the same LclPackageId:
We need to understand from the loc team how new branches are supposed to work, because having it copy translations from a different branch feels broken. For example, we don't want 7.3.x's translations to flow back to 7.0.x once they change their configuration for which branch they track.
There was a problem hiding this comment.
However, the 7.0.x translation: https://github.com/NuGet/NuGet.Client/blame/release/7.0.x/src/NuGet.Clients/NuGet.PackageManagement.UI/Options/xlf/GeneralOptionControl.pl.xlf#L7C20-L7C20
is newer than the dev branch & 7.3.x translation: https://github.com/NuGet/NuGet.Client/blame/dev/src/NuGet.Clients/NuGet.PackageManagement.UI/Options/xlf/GeneralOptionControl.pl.xlf#L7
So maybe the change is good, and it's a bug that the same translation didn't flow to the dev branch?
There was a problem hiding this comment.
Previously, we were only localizing the dev and latest release branches only. We need to change the pipeline.yml to only run OneLock task for those 2 branches. LCL-JUNO-PROD-NuGetClientRel is a package that gets created every time we run OneLoc, so now we are mixing multiple branches into the same package.
I think there still an error in localization like Andy pointed out, 7.0.x has a newer translation than other branches. This could be because since they are 2 different packages (LCL-JUNO-PROD-NuGetClientRel for release branch and LCL-JUNO-PROD-NuGetClient for dev branch) they are not "sync". So, I think the tool suggested the translation update to just one package.
There was a problem hiding this comment.
It looks to me like msbuild use the same LclPackageId for all release branches, not just the latest branch: https://github.com/dotnet/msbuild/blob/d7c46dace72bdf286c1ff3a5dbeaf1d9bc36152d/.vsts-dotnet.yml#L103-L108
If that's a problem, I'd like to know more about how they deal with it.
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
…: Build ID 13151130
…: Build ID 13151130
…: Build ID 13151130
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
dotnet-bot
changed the title
|
@NuGet/nuget-client Looks like this is good now, no "new" strings and look like valid translations after OneLoc changed the target branch. I created a ticket with questions about branching https://ceapex.visualstudio.com/CEINTL/_workitems/edit/1127310, let me know if you agree to merge or have questions |
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.