Stop using the consumption feed, use VSSDK and vs-impl directly #7046
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
added
the
Engineering
dotnet-policy-service
bot
added
the
Status:No recent activity
nkolev92
force-pushed
the
dev-nkolev92-stopUsingConsumption
branch
from
7848fc9 to
23acb0e
Compare
dotnet-policy-service
bot
removed
the
Status:No recent activity
dotnet-policy-service
bot
added
the
Status:No recent activity
Contributor
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/nuget/client.engineering/issues/2877
Description
Follow up to the challenges in #7036.
The consumption feed needs to be managed to bring in new packages and for that reason we have been using the local view of it.
The better solution and what other public products like roslyn are doing is referencing the vs-impl and vssdk feeds: https://github.com/dotnet/roslyn/blob/main/NuGet.config.
I also added a note that we probably want to duplicate these mappings across the 2 feeds. There are redundancies, but my thinking right now is it would be simpler to do.
If people think the redundancies are not fine, I'd be happy to try and clean them up.
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.