-
-
Notifications
You must be signed in to change notification settings - Fork 456
[18.0][IMP] crm_phonecall: Add computed partner city/state/zip fields #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
Jaimermaccione
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anxo82 Functional reviewed on local environment:
In both list and form views, we can see the following fields from the related contact:
- ZIP code
- State (Province)
- Country
These fields are automatically populated with the data associated to the linked contact.
Issues Found
Minor
- In the list view, the field labels are not translated into Spanish.
- Please ensure that "State Name" is translated as "Provincia" to avoid confusion with the translation of "Status" (Estado).
- The same issue applies to filters and group-by options: the terms ZIP, State Name, and City appear untranslated.
- While reviewing translations, please also check their Catalan equivalents.
Blocking
- In the Call Analysis report (
crm.phonecall.report), when attempting to group by any of the new fields (ZIP, State Name, or City), an Odoo server error is raised:
Error de servidor de Odoo
RPC_ERROR
Odoo Server Error
Occured on localhost:18069 on model crm.phonecall.report on 2026-01-08 07:58:22 GMT
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 2144, in _transactioning
return service_model.retrying(func, env=self.env)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 156, in retrying
result = func()
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 2111, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 2359, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_http.py", line 333, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 754, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/auto/addons/web/controllers/dataset.py", line 36, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 535, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 2887, in read_group
rows = self._read_group(domain, annotated_groupby.values(), annotated_aggregates.values(), offset=offset, limit=limit, order=orderby)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 2021, in _read_group
row_values = self.env.execute_query(query.select(*[groupby_terms[spec] for spec in groupby], *select_terms))
File "/opt/odoo/custom/src/odoo/odoo/api.py", line 993, in execute_query
self.cr.execute(query)
File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 357, in execute
res = self._obj.execute(query, params)
psycopg2.errors.UndefinedColumn: column crm_phonecall_report.partner_city does not exist
LINE 1: SELECT "crm_phonecall_report"."partner_city", date_trunc('mo...
^
HINT: Perhaps you meant to reference the column "crm_phonecall_report.partner_id".
The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://localhost:18069/web/assets/ba92c49/web.assets_web.min.js:3148:163)
at XMLHttpRequest.<anonymous> (http://localhost:18069/web/assets/ba92c49/web.assets_web.min.js:3153:13)
- Additionally, when applying filters using those same fields, an error is shown indicating that the domain is invalid.
Summary
- Basic functional behavior is correct (fields are visible and auto-filled).
- Minor issues with translations in views and filters.
- Critical issue when grouping or filtering by new fields in reports
bb25d82 to
d73421c
Compare
|
@Jaimermaccione I have tested this through the runbot and it works correctly. It seems the issue was related to the local database being used. Translations have been regenerated. |
Perfect! @Anxo82 I’ve re-tested on my side after updating/regenerating the translations and the issue persists. Current behavior:
So at least in runboat, the translations are still not fully applied in those views. Let me know if you want me to test a specific commit or scenario. Thanks!! |
d73421c to
fea2480
Compare



@HaraldPanten @ValentinVinagre
[T-9197]